dns v2 - both empty string and default should be allowed for namespace and partition in CE #21230
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmurret
added
the
backport/1.19
…e and partition in Ce
jmurret
force-pushed
the
jm/dns-v2-tenancy-validation
branch
from
5d12cb5 to
329bdc1
Compare
zalimeni
approved these changes
May 28, 2024
zalimeni
reviewed
May 28, 2024
Comment on lines
+11
to
+28
| // NonEmptyDefaultPartitionName is the name of the default partition that is | ||
| // not empty. An example of this being supplied is when a partition is specified | ||
| // in the request for DNS by consul-dataplane. This has been added to support | ||
| // DNS v1.5, which needs to be compatible with the original DNS subsystem which | ||
| // supports partition being "default" or empty. Otherwise, use DefaultPartitionName. | ||
| NonEmptyDefaultPartitionName = "default" | ||
|
|
||
| // DefaultNamespaceName is used to mimic the behavior in consul/structs/intention.go, | ||
| // where we define IntentionDefaultNamespace as 'default' and so we use the same here. | ||
| // This is a little bit strange; one might want it to be "" like DefaultPartitionName. | ||
| DefaultNamespaceName = "default" | ||
|
|
||
| // Reviewer Note: This is a little bit strange; one might want it to be "" like partition name | ||
| // However in consul/structs/intention.go we define IntentionDefaultNamespace as 'default' and so | ||
| // we use the same here | ||
| const DefaultNamespaceName = "default" | ||
| // EmptyNamespaceName is the name of the default partition that is an empty string. | ||
| // An example of this being supplied is when a namespace is specifiedDNS v1. | ||
| // EmptyNamespaceName has been added to support DNS v1.5, which needs to be | ||
| // compatible with the original DNS subsystem which supports partition being "default" or empty. | ||
| // Otherwise, use DefaultNamespaceName. | ||
| EmptyNamespaceName = "" |
zalimeni
approved these changes
May 28, 2024
4 tasks
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
tenancy was being validated on DNS queries from consul-dataplane to only allow partition to be set to an empty string. It was not allow
defaultin either case.Testing & Reproduction steps
Links
PR Checklist