Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport of dns v2 - both empty string and default should be allowed for namespace and partition in CE into release/1.19.x #21233

Conversation

hc-github-team-consul-core
Copy link
Collaborator

Backport

This PR is auto-generated from #21230 to be assessed for backporting due to the inclusion of the label backport/1.19.

The below text is copied from the body of the original PR.


Description

tenancy was being validated on DNS queries from consul-dataplane to only allow partition to be set to an empty string. It was not allow default in either case.

Testing & Reproduction steps

Links

PR Checklist

  • updated test coverage
  • external facing docs updated
  • appropriate backport labels added
  • not a security concern

Overview of commits

@hc-github-team-consul-core hc-github-team-consul-core requested a review from a team as a code owner May 28, 2024 22:21
@hc-github-team-consul-core hc-github-team-consul-core force-pushed the backport/jm/dns-v2-tenancy-validation/shortly-literate-seasnail branch from 925b2fd to b5527b1 Compare May 28, 2024 22:21
@zalimeni zalimeni enabled auto-merge (squash) May 28, 2024 22:21
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto approved Consul Bot automated PR

@github-actions github-actions bot added the theme/acls ACL and token generation label May 28, 2024
@zalimeni zalimeni merged commit 408ed18 into release/1.19.x May 28, 2024
83 checks passed
@zalimeni zalimeni deleted the backport/jm/dns-v2-tenancy-validation/shortly-literate-seasnail branch May 28, 2024 22:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
theme/acls ACL and token generation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants