Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump Envoy Versions #21277

Merged
merged 3 commits into from
Jun 10, 2024
Merged

Bump Envoy Versions #21277

merged 3 commits into from
Jun 10, 2024

Conversation

sarahalsmiller
Copy link
Member

Description

Bump Envoy versions

Testing & Reproduction steps

Links

PR Checklist

  • updated test coverage
  • external facing docs updated
  • appropriate backport labels added
  • not a security concern

@github-actions github-actions bot added type/ci Relating to continuous integration (CI) tooling for testing or releases theme/contributing Additions and enhancements to community contributing materials labels Jun 6, 2024
@sarahalsmiller sarahalsmiller marked this pull request as ready for review June 7, 2024 16:17
@dduzgun-security dduzgun-security self-requested a review June 7, 2024 19:58
dduzgun-security
dduzgun-security approved these changes Jun 7, 2024
View reviewed changes
Copy link
Contributor

@dduzgun-security dduzgun-security left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks a lot for taking a look into this

@sarahalsmiller sarahalsmiller added backport/ent/1.17 Changes are backported to 1.17 ent backport/ent/1.15 Changes are backported to 1.15 ent backport/1.19 Changes are backported to 1.19 backport/1.18 This release series is longer active on CE, use backport/ent/1.18 backport/ent/1.16 This release series is longer active on CE or Ent labels Jun 10, 2024
@sarahalsmiller sarahalsmiller enabled auto-merge (squash) June 10, 2024 15:16
@sarahalsmiller sarahalsmiller merged commit 2cdc387 into main Jun 10, 2024
86 checks passed
@sarahalsmiller sarahalsmiller deleted the bump-envoy-version branch June 10, 2024 15:29
This was referenced Jun 10, 2024
Merged
Merged
nathancoleman
nathancoleman reviewed Jun 10, 2024
View reviewed changes
.github/workflows/nightly-test-integrations-1.18.x.yml
@@ -109,7 +109,7 @@ jobs:
strategy:
fail-fast: false
matrix:
envoy-version: ["1.24.12", "1.25.11", "1.26.8", "1.27.5"]
envoy-version: ["1.24.12", "1.25.11", "1.26.8", "1.27.6"]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wondering if this list should have included 1.28.5

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good observation, since we have a task for the next release to bump Envoy to all the latest and greatest stable versions we decided to update the currently existing ones to fix the CVEs so we have less friction for the current release.

@zalimeni zalimeni mentioned this pull request Jun 11, 2024
Merged
4 tasks
@hc-github-team-consul-core
Copy link
Collaborator

@sarahalsmiller, a backport is missing for this PR [21277] for versions [1.15,1.16,1.19] please perform the backport manually and add the following snippet to your backport PR description:

<details>
	<summary> Overview of commits </summary>
		- <<backport commit 1>>
		- <<backport commit 2>>
		...
</details>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nathancoleman nathancoleman nathancoleman left review comments

@dduzgun-security dduzgun-security dduzgun-security approved these changes

Assignees
No one assigned
Labels
backport/ent/1.15 Changes are backported to 1.15 ent backport/ent/1.16 This release series is longer active on CE or Ent backport/ent/1.17 Changes are backported to 1.17 ent backport/1.18 This release series is longer active on CE, use backport/ent/1.18 backport/1.19 Changes are backported to 1.19 theme/contributing Additions and enhancements to community contributing materials type/ci Relating to continuous integration (CI) tooling for testing or releases
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sarahalsmiller @hc-github-team-consul-core @nathancoleman @dduzgun-security