Backport of Bump Envoy Versions into release/1.18.x #21290
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-team-consul-core-pr-approver
approved these changes
Jun 10, 2024
|
|
sarahalsmiller
force-pushed
the
backport/bump-envoy-version/basically-obliging-anteater
branch
from
79a5548 to
fda8939
Compare
nathancoleman
requested changes
Jun 10, 2024
| @@ -305,7 +305,7 @@ jobs: | |||
| strategy: | |||
| fail-fast: false | |||
| matrix: | |||
| envoy-version: ["1.28.3"] | |||
| envoy-version: ["1.29.5"] | |||
There was a problem hiding this comment.
Should this be 1.28.4? It looks like Consul 1.18 doesn't support Envoy 1.29.5
nathancoleman
approved these changes
Jun 10, 2024
sarahalsmiller
deleted the
backport/bump-envoy-version/basically-obliging-anteater
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport
This PR is auto-generated from #21277 to be assessed for backporting due to the inclusion of the label backport/1.18.
🚨
The person who merged in the original PR is:
@sarahalsmiller
This person should manually cherry-pick the original PR into a new backport PR,
and close this one when the manual backport PR is merged in.
The below text is copied from the body of the original PR.
Description
Bump Envoy versions
Testing & Reproduction steps
Links
PR Checklist
Overview of commits