Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

return configured domain in reverse PTR instead of .consul. #582

Closed
dankennedy opened this issue Jan 7, 2015 · 1 comment
Closed

return configured domain in reverse PTR instead of .consul. #582

dankennedy opened this issue Jan 7, 2015 · 1 comment
Labels
type/bug Feature does not function as expected

Comments

@dankennedy
Copy link
Contributor

I'm using the reverse lookup function added very recently and while it returns the correct result it always returns the node name as machine1.node.dc.consul even though we have a domain configured in server.json of blah, so I would expect the answer to be machine1.node.dc.blah

Firstly is my assumption correct? If so, I'll create a PR to update it.

Thanks

Finally just wanted to express my thanks/appreciation for consul as a whole. Great work.
@armon armon added the type/bug Feature does not function as expected label Jan 7, 2015
@armon
Copy link
Member

armon commented Jan 7, 2015

Definitely a bug! Marking as a bug so we can fix, but would love a PR as well :)

@armon armon closed this as completed in 63af8d0 Jan 8, 2015
armon added a commit that referenced this issue Jan 8, 2015
@armon
Merge pull request #586 from dankennedy/master
d5f1411 
replaced consul domain with configured domain. Fixes #582
duckhan pushed a commit to duckhan/consul that referenced this issue Oct 24, 2021
Update config-checksum annotation on config changes (hashicorp#582)
0e7dae4 
- The `config-checksum` annotation on the server-stateful and
  client-daemonset would previously only updated on changes to their
respective extraConfig. This would fail to restart the server when ACL
config was updated. The behaviour has been updated to hash the entire
contents of the server/client config configmap so that any changes to
the configmap will force a recreate of the server/client pods. This will
allows consul upgrades to update an insecure install to a secure one.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type/bug Feature does not function as expected
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@armon @dankennedy