Add options to send telemetry to DogStatsD #1293
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 |
|
Seems like some merge conflicts have appeared, will rebase on master. |
|
Hey guys, friendly ping on this. I resolved merge conflicts with master and also removed an unused import here that was causing CI to fail. let me know! |
slackpad
added a commit
that referenced
this pull request
Nov 13, 2015
Add options to send telemetry to DogStatsD
|
Rebase looks good - thanks! |
notnoopci
added a commit
to circleci/nomad
that referenced
this pull request
Feb 6, 2018
Expose an global tags option in telemtry config for dogstatsd, for purposes of distinguishing between multiple nomad cluster metrics. This is close in spirit to hashicorp/consul#1293
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The changeset at hashicorp/go-metrics#19 added a DogStatsD sink, that satisfies the interface Consul requires for its runtime telemetry. It would be nice to have top-level configuration options in Consul for the initialization and use of this sink, similar to the options for vanilla statsd and statsite.
This PR adds 2 configuration options:
dogstatsd_addr: The address of a DogStatsD instancedogstatsd_tags: A list of tags of the format["my_tag_1:my_value_1", "my_tag_2:my_value_2"]. These tags will be appended to all runtime telemetry packets sent by Consul and can be leveraged in the Datadog graphing backend. Ref: http://docs.datadoghq.com/guides/tagging/