Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed deprecated method calls. #13424

Closed
wants to merge 3 commits into from

Conversation

bootjp
Copy link

@bootjp bootjp commented Jun 12, 2022

Description

Changed deprecated receiver calls.

Testing & Reproduction steps

  • In the case of bugs, describe how to replicate
  • If any manual tests were done, document the steps and the conditions to replicate
  • Call out any important/ relevant unit tests, e2e tests or integration tests you have added or are adding

Links

Include any links here that might be helpful for people reviewing your PR (Tickets, GH issues, API docs, external benchmarks, tools docs, etc). If there are none, feel free to delete this section.

Please be mindful not to leak any customer or confidential information. HashiCorp employees may want to use our internal URL shortener to obfuscate links.

PR Checklist

  • updated test coverage
  • external facing docs updated
  • not a security concern

@hashicorp-cla
Copy link

hashicorp-cla commented Jun 12, 2022

CLA assistant check
All committers have signed the CLA.

@bootjp bootjp marked this pull request as ready for review June 12, 2022 11:52
@bootjp bootjp changed the title migrate deprecated Changed deprecated receiver calls. Jun 12, 2022
@bootjp bootjp changed the title Changed deprecated receiver calls. Changed deprecated method calls. Jun 13, 2022
@Amier3
Copy link
Contributor

Amier3 commented Jun 13, 2022

Hey @bootjp

Thank you for making this change! We're close to a new release so it may take us a bit of time to get this reviewed -- but we appreciate the PR. In my opinion, using the readTxn() interface is a lot cleaner than our current implementation.

On the raftApplyMsgpack changes, the raftApply func is currently calling raftApplyMsgpack anyway ( see: #9991 (comment) ) so i'm not sure if there's any reason we can't call raftApplyMsgpack directly. I'll have to ask around and we'll get back to you with feedback shortly 😄 .

@bootjp
Copy link
Author

bootjp commented Jun 13, 2022

Thank you for your reply while you are busy. I will wait slowly so please don't worry.

@github-actions
Copy link

This pull request has been automatically flagged for inactivity because it has not been acted upon in the last 60 days. It will be closed if no new activity occurs in the next 30 days. Please feel free to re-open to resurrect the change if you feel this has happened by mistake. Thank you for your contributions.

@github-actions github-actions bot added the meta/stale Automatically flagged for inactivity by stalebot label Aug 13, 2022
@github-actions
Copy link

Closing due to inactivity. If you feel this was a mistake or you wish to re-open at any time in the future, please leave a comment and it will be re-surfaced for the maintainers to review.

@github-actions github-actions bot closed this Sep 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
meta/stale Automatically flagged for inactivity by stalebot
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants