Uses correct version for automatic upshift, sets coordinate Raft log entries to ignore. #1353
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| return false, err | ||
| } | ||
|
|
||
| if vsn >= int(version) { |
There was a problem hiding this comment.
Should there also be a <= here for the vsn_min? Likely wouldn't see that any time soon I guess.
There was a problem hiding this comment.
Good call. It's more important to have old clients do this right than newer ones so I'll add the full interval check.
|
Just one comment (more of a question), but LGTM! |
|
Build fails are transient and not related to these changes. |
slackpad
added a commit
that referenced
this pull request
Oct 27, 2015
Uses correct version for automatic upshift, sets coordinate Raft log entries to ignore.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix #1346.