[CI-only] Update dev image tagging on 1.11.x #13539
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
theme/contributing
mdeggies
commented
Jun 21, 2022
| // | ||
| // Version must conform to the format expected by github.com/hashicorp/go-version | ||
| // for tests to work. | ||
| Version = "1.11.3" | ||
| Version = "1.11.7" |
There was a problem hiding this comment.
Since the current version of consul on release/1.11.x is 1.11.6, this has been bumped to the NEXT version, 1.11.7. After 1.11.7 is released, this version should be bumped to 1.11.8 if there will be another patch in this series.
mdeggies
added
pr/no-changelog
This was referenced Jun 21, 2022
|
This was reviewed for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Pushing per-commit dev images to the
hashicorppreviewdockerhub org was introduced in #13084, but the tag names have been unclear.This PR has been created to follow the guidance outlined in https://docs.google.com/document/d/1ovhf8DmlXbsuc45HkN7LdsrS2J3evfSvcy2LPiyUgZ8/edit for dev image naming, and for keeping the version string in
version.goup to date. There are two parts to this:version.goon each active release branch, and onmain, updated after a release to point to the next minor or major version string. For example, after releasing consul1.11.6from branchrelease/1.11.x, the version string inversion.goonrelease/1.11.xshould be updated to1.11.7.dev_tags, the set of tags that are created for per-commit docker image builds, will be stripped of the patch version. For example, onrelease/1.11.x, the dev_tags that will be published off of this release branch will be namedhashicorppreview/consul:1.11-devandhashicorppreview/consul:1.11-dev-$COMMITSHA.hashicorppreview/consul:1.11-devwill be kept up to date with the latest builds from branchrelease/1.11.x.Testing & Reproduction steps
Dev tags published on this release branch will be named in the following format:
hashicorppreview/consul:1.11-dev,hashicorppreview/consul:1.11-$COMMITSHA-dev. See https://hub.docker.com/r/hashicorppreview/consul/tags?page=1&name=1.11-dev to pull the dev image built from commit 263422c (https://github.com/hashicorp/consul/runs/6994186153) from this PR.Other PR's in this series
Changes to target release/1.12.x: #13540
Changes to target main: #13541