Update go-memdb to fix a goroutine leak #15068
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kisunji
requested review from
a team and
banks
and removed request for
a team
github-actions
bot
added
the
pr/dependencies
huikang
approved these changes
Oct 20, 2022
nathancoleman
approved these changes
Oct 20, 2022
|
Seems like go-tests is failing even on rerun 👀 |
Checking now. Looks unrelated to the bugfix so I'll bisect the previous version too (v1.3.3) |
|
Confirming that the tests are failing at 1.3.3. May be that some indexer behaviors got changed |
kisunji
commented
Oct 20, 2022
| @@ -226,7 +226,7 @@ func testIndexerTableGatewayServices() map[string]indexerTestCase { | |||
| Service: structs.ServiceName{Name: "SerVice"}, | |||
| Port: 50123, | |||
| } | |||
| encodedPort := string([]byte{0x96, 0x8f, 0x06, 0, 0, 0, 0, 0, 0, 0}) | |||
| encodedPort := string([]byte{0x80, 0, 0, 0, 0, 0, 0xc3, 0xcb}) | |||
There was a problem hiding this comment.
The way integers were encoded was updated in go-memdb@v1.3.3 by hashicorp/go-memdb#114
kisunji
force-pushed
the
kisunji/update-gomemdb
branch
from
7114708
to
13d8f41
Compare
added 3 commits
October 20, 2022 14:32
go-memdb was updated in v1.3.3 to make integers in indexes sortable, which changed how integers were encoded.
kisunji
force-pushed
the
kisunji/update-gomemdb
branch
from
13d8f41
to
a7ea261
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
go-memdb was updated to fix a goroutine leak: hashicorp/go-memdb#128
Fixes #15010