Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport of ui: Add ServerExternalAddresses to peer token create form into release/1.14.x #15620

Conversation

hc-github-team-consul-core
Copy link
Collaborator

Backport

This PR is auto-generated from #15555 to be assessed for backporting due to the inclusion of the label backport/1.14.

The below text is copied from the body of the original PR.


Description

To support HCP Cluster Peering, an additional text input needs to be added to the Create Peering modal for fallback server addresses.

2022-11-25 10-04-46 2022-11-25 10_06_03

Testing & Reproduction steps

To test against a real API you can do the following:

  • Checkout this branch
  • Run make ui-docker. This will take an eternity.
  • Run make dev-docker
  • Clone https://github.com/WenInCode/consul-setup
  • go to consul-setup/setups/peering
  • yarn
  • docker-compose up
  • once the docker container is up and running, run yarn setup:peerings
  • Go to https://localhost:8501/ui
  • Go to the peers page and create a new peering token to test out adding fallback addresses.
  • You can observe the parameter being sent over in the network tab.

Links


Overview of commits

@hc-github-team-consul-core hc-github-team-consul-core force-pushed the backport/ui/add-peering-addresses-field/smoothly-advanced-foxhound branch from 91d7ad9 to d0c076b Compare November 30, 2022 18:43
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto approved Consul Bot automated PR

@github-actions github-actions bot added the theme/ui Anything related to the UI label Nov 30, 2022
@hc-github-team-consul-core hc-github-team-consul-core merged commit 13836d5 into release/1.14.x Nov 30, 2022
@hc-github-team-consul-core hc-github-team-consul-core deleted the backport/ui/add-peering-addresses-field/smoothly-advanced-foxhound branch November 30, 2022 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
theme/ui Anything related to the UI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants