feat: add access logging API to proxy defaults #15780
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DanStough
added
pr/no-changelog
DanStough
force-pushed
the
dans/NET-1752/proxy-defaults-access-logs
branch
from
a0dd833 to
d9b1431
Compare
thisisnotashwin
approved these changes
Dec 13, 2022
DanStough
force-pushed
the
dans/NET-1752/proxy-defaults-access-logs
branch
from
d9b1431 to
d6155f2
Compare
t-eckert
pushed a commit
that referenced
this pull request
Dec 15, 2022
This was referenced Dec 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR is for Consul API changes to enable access logging.
Eventually, the
AcessLogsConfigstruct will make it intoConnectProxyConfigin a follow-on story that plumb this configuration into the listener generation.Testing & Reproduction steps
PR Checklist
external facing docs updatednot a security concern