Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update config-entry ingress-gateway.mdx doc with correct fields for Passive Health Check. #15905

Closed
wants to merge 8 commits into from

Conversation

shweshi
Copy link

@shweshi shweshi commented Jan 5, 2023

Update doc with correct fields for PassiveHealthCheck.

Description

Updating the PassiveHealthCheck fields with correct names..

Testing & Reproduction steps

  • In the case of bugs, describe how to replicate
  • If any manual tests were done, document the steps and the conditions to replicate
  • Call out any important/ relevant unit tests, e2e tests or integration tests you have added or are adding

Links

Include any links here that might be helpful for people reviewing your PR (Tickets, GH issues, API docs, external benchmarks, tools docs, etc). If there are none, feel free to delete this section.

Please be mindful not to leak any customer or confidential information. HashiCorp employees may want to use our internal URL shortener to obfuscate links.

PR Checklist

  • updated test coverage
  • external facing docs updated
  • not a security concern

Update doc with correct fields for PassiveHealthCheck.
@shweshi shweshi requested a review from a team as a code owner January 5, 2023 12:35
@github-actions github-actions bot added the type/docs Documentation needs to be created/updated/clarified label Jan 5, 2023
@shweshi shweshi changed the title Update ingress-gateway.mdx Update config-entry ingress-gateway.mdx doc with correct fields for Passive Health Check. Jan 5, 2023
@shweshi
Copy link
Author

shweshi commented Jan 19, 2023

@huikang can we get this review and merge Or can #15614 be updates with the correct config names. Added comments in #15614

@shweshi
Copy link
Author

shweshi commented Feb 10, 2023

@huikang can you review this or update the #15614

@shweshi
Copy link
Author

shweshi commented Feb 12, 2023

@huikang can this be merged. What else is needed for getting this merge.

Also when this will be available i see the backport to 1.14 label is removed. What's the plan to release it.

@github-actions
Copy link

This pull request has been automatically flagged for inactivity because it has not been acted upon in the last 60 days. It will be closed if no new activity occurs in the next 30 days. Please feel free to re-open to resurrect the change if you feel this has happened by mistake. Thank you for your contributions.

@github-actions github-actions bot added the meta/stale Automatically flagged for inactivity by stalebot label Jun 22, 2023
Copy link

github-actions bot commented Jun 3, 2024

Closing due to inactivity. If you feel this was a mistake or you wish to re-open at any time in the future, please leave a comment and it will be re-surfaced for the maintainers to review.

@github-actions github-actions bot closed this Jun 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
meta/stale Automatically flagged for inactivity by stalebot type/docs Documentation needs to be created/updated/clarified
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants