Backport of Inline API Gateway TLS cert code into release/1.15.x #16306
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hc-github-team-consul-core
force-pushed
the
backport/api-gateway-inline/gratefully-current-terrier
branch
2 times, most recently
from
3ec24d2 to
2524d13
Compare
github-team-consul-core-pr-approver
approved these changes
Feb 17, 2023
* Include secret type when building resources from config snapshot * First pass at generating envoy secrets from api-gateway snapshot * Update comments for xDS update order * Add secret type + corresponding golden files to existing tests * Initialize test helpers for testing api-gateway resource generation * Generate golden files for new api-gateway xDS resource test * Support ADS for TLS certificates on api-gateway * Configure TLS on api-gateway listeners * Inline TLS cert code * update tests * Add SNI support so we can have multiple certificates * Remove commented out section from helper * regen deep-copy * Add tcp tls test --------- Co-authored-by: Nathan Coleman <nathan.coleman@hashicorp.com>
andrewstucki
force-pushed
the
backport/api-gateway-inline/gratefully-current-terrier
branch
from
2524d13 to
16396b6
Compare
added 2 commits
February 17, 2023 13:30
…ully-current-terrier
andrewstucki
deleted the
backport/api-gateway-inline/gratefully-current-terrier
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport
This PR is auto-generated from #16295 to be assessed for backporting due to the inclusion of the label backport/1.15.
WARNING automatic cherry-pick of commits failed. Commits will require human attention.
The below text is copied from the body of the original PR.
Description
We initially attempted to ship API Gateway certificates via SDS secrets over ADS, however, currently certificates pushed down via ADS never come out of a warming state. This acts as a stop-gap to try and ship certificates to API Gateways without requiring having a fully functioning ADS secret pushdown.
In order to implement binding multiple certificates to a gateway listener it adds some SNI behavior to the gateways, specifically the xDS generation code, when applying a single certificate leverages it for all traffic. For multiple certificates it:
The above overlapping check to a default listener was done to make things deterministic rather than based off of something like which cert was created first.
In the future I think we should talk to the upstream community about the possibility of either adding an optional flag for a certificate to be the
defaultcertificate, or potentially adding an optionalhostnamesfield to the certificate references so that an implementation can just leverage that rather than trying to construct a non-overlapping hostnames set themselves, or both (this is a generic multi-cert problem).PR Checklist
Overview of commits