Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor and move wal docs #16387
Refactor and move wal docs #16387
Changes from 17 commits
769bbb7
864b8e8
8cba2cd
56a554a
b301bf9
b4b92c8
905bd70
ea0df5c
5328ea2
837bc53
22a4aad
c3e53c3
5b7e152
3614ab1
e98acef
ba80be3
184d26e
ad8dab0
ae37131
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a pronoun I couldn't parse, so please verify.
In the following sentence: "The only correct response is to stop the server, remove its data directory, and restart so it can be caught back up with a correct server again."
The "it" after the so - what is it that's catching up with a correct server again? As written is says: "These actions catch up the server with a correct server again." I replaced the "it" with "data directory" - the only other thing in the sentence it could refer to.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I missed that. IMO would read more clearly as
Does that read better to you @boruszak?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oops saw this was merged. Nevermind!