Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backport of added a backport-checker GitHub action into release/1.15.x #16584

Merged
merged 3 commits into from
Mar 9, 2023
Merged

Backport of added a backport-checker GitHub action into release/1.15.x #16584

merged 3 commits into from
Mar 9, 2023

Conversation

hc-github-team-consul-core
Copy link
Collaborator

Backport

This PR is auto-generated from #16567 to be assessed for backporting due to the inclusion of the label backport/1.15.

The below text is copied from the body of the original PR.

Description

  • Add a pipeline check for backport labels. This will ensure that developers must either add a backport label or deliberately specify that this pr does not require backporting with the pr/no-backport label.
  • This check simply checks for the presence of a label matching backport/*. It is up to the developer to add the right backport labels as appropriate for a given PR.

How I've tested this PR:

No Backport label and no pr/no-backport
image

With backport label
image

With pr/no-backport label
image

PR Checklist

  • [n/a] updated test coverage
  • [n/a] external facing docs updated
  • not a security concern
Overview of commits

@hc-github-team-consul-core hc-github-team-consul-core force-pushed the backport/mw/add-backport-label-check/presumably-great-wallaby branch from 7c66ffd to dff521c Compare March 9, 2023 16:41
@hc-github-team-consul-core hc-github-team-consul-core enabled auto-merge (squash) March 9, 2023 16:41
github-team-consul-core-pr-approver
github-team-consul-core-pr-approver approved these changes Mar 9, 2023
View reviewed changes
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto approved Consul Bot automated PR

@github-actions github-actions bot added the theme/contributing Additions and enhancements to community contributing materials label Mar 9, 2023
@wilkermichael wilkermichael disabled auto-merge March 9, 2023 20:40
@wilkermichael wilkermichael merged commit 57ad7e0 into release/1.15.x Mar 9, 2023
@wilkermichael wilkermichael deleted the backport/mw/add-backport-label-check/presumably-great-wallaby branch March 9, 2023 20:40
@jjti jjti mentioned this pull request Aug 28, 2023
Closed
@dlaguerta dlaguerta mentioned this pull request Dec 1, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-team-consul-core-pr-approver github-team-consul-core-pr-approver github-team-consul-core-pr-approver approved these changes

@wilkermichael wilkermichael Awaiting requested review from wilkermichael

Assignees
No one assigned
Labels
theme/contributing Additions and enhancements to community contributing materials
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hc-github-team-consul-core @github-team-consul-core-pr-approver @wilkermichael