-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix audit-log encoding issue (CC-7337) #20345
Merged
Merged
Changes from all commits
Commits
Show all changes
30 commits
Select commit
Hold shift + click to select a range
d62a35f
Merge branch 'main' of ssh://github.com/hashicorp/consul
absolutelightning d883550
Merge branch 'main' of ssh://github.com/hashicorp/consul
absolutelightning 87b6971
Merge branch 'main' of ssh://github.com/hashicorp/consul
absolutelightning c418689
Merge branch 'main' of ssh://github.com/hashicorp/consul
absolutelightning 9008b22
Merge branch 'main' of ssh://github.com/hashicorp/consul
absolutelightning 07af66c
Merge branch 'main' of ssh://github.com/hashicorp/consul
absolutelightning 6ff9fe9
Merge branch 'main' of ssh://github.com/hashicorp/consul
absolutelightning d98d6af
Merge branch 'main' of ssh://github.com/hashicorp/consul
absolutelightning 5b1cc3c
Merge branch 'main' of ssh://github.com/hashicorp/consul
absolutelightning a64a031
Merge branch 'main' of ssh://github.com/hashicorp/consul
absolutelightning 9377ca6
Merge branch 'main' of ssh://github.com/hashicorp/consul
absolutelightning e3f2751
Merge branch 'main' of ssh://github.com/hashicorp/consul
absolutelightning 01ac423
Merge branch 'main' of ssh://github.com/hashicorp/consul
absolutelightning 8fd5619
Merge branch 'main' of ssh://github.com/hashicorp/consul
absolutelightning 54f5c2d
Merge branch 'main' of ssh://github.com/hashicorp/consul
absolutelightning 0f247ba
Merge branch 'main' of ssh://github.com/hashicorp/consul
absolutelightning e6dbfb8
Merge branch 'main' of ssh://github.com/hashicorp/consul
absolutelightning c12c127
add changes
absolutelightning aace885
added changelog
absolutelightning 35f4f20
change update
absolutelightning 2b9199d
Merge branch 'main' into CC-7337
absolutelightning e0062ec
Merge branch 'main' into CC-7337
abhishek-hashicorp d652e21
Merge branch 'main' of ssh://github.com/hashicorp/consul into CC-7337
absolutelightning fc7bfda
CE chnages
absolutelightning da4b4fb
fixes
absolutelightning 0f99aa6
Removed gzip size fix
absolutelightning 28f6aa6
fix changelog
absolutelightning 029632a
Update .changelog/20345.txt
absolutelightning 7e41089
Adding comments
13d6350
Merge branch 'main' into CC-7337
absolutelightning File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,3 @@ | ||
```release-note:bug | ||
audit-logs: **(Enterprise Only)** Fixes non ASCII characters in audit logs because of gzip. | ||
``` |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You sure that this line can be safely removed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hander(resp, req)
is called inside https://github.com/hashicorp/consul/pull/20345/files#diff-ad6af77036bc1fef503bdda8fcfca16347a3ef985dc9defbe9d915d4c106524dR99looks same for CE.
Is there an issue?