NET-5398: V2 unavailable UI message #20359
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WenInCode
force-pushed
the
NET-5398/v2-unavailable-ui
branch
from
c08a36a to
f5a848c
Compare
WenInCode
commented
Jan 26, 2024
| {{#if (env 'CONSUL_V2_CATALOG_ENABLED')}} | ||
| <div class='h-screen w-full flex flex-col justify-center items-center'> | ||
| <div> | ||
| <svg |
There was a problem hiding this comment.
I just used an SVG here from the figma because this is a logo with the text, but the text is using our marketing fonts (?).
WenInCode
force-pushed
the
NET-5398/add-V2Enabled-to-config
branch
from
32a25b8 to
2b8feba
Compare
WenInCode
force-pushed
the
NET-5398/v2-unavailable-ui
branch
from
3f9d066 to
56ddeea
Compare
chris-hut
approved these changes
Jan 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is currently based off #20353 until that gets merged
Adds a redirect to a
/unavailablepage that shows a message about the UI being unvailable if you have v2 experiment enabled. It also redirects away from the unavailable page if it is not enabled.Testing & Reproduction steps
I mainly tested this by building Consul and enabling the experiment in the server config and then opening the UI (steps in this ticket).
You can do the naïve test as well by running this against the mocks and then running
Scenario('CONSUL_V2_CATALOG_ENABLE=1')in the console.Links
#20353
https://hashicorp.atlassian.net/browse/NET-5398
https://hashicorp.atlassian.net/browse/CC-6956
PR Checklist