Backport of fix(v2dns): add node ttl to workloads, comment cleanup, and changelog into release/1.18.x #20650
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hc-github-team-consul-core
force-pushed
the
backport/dans/NET-7485/docs/similarly-cool-alpaca
branch
from
1159272 to
86ab520
Compare
hc-github-team-consul-core
force-pushed
the
backport/dans/NET-7485/docs/similarly-cool-alpaca
branch
from
4457e56 to
9253403
Compare
github-team-consul-core-pr-approver
approved these changes
Feb 14, 2024
DanStough
deleted the
backport/dans/NET-7485/docs/similarly-cool-alpaca
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport
This PR is auto-generated from #20643 to be assessed for backporting due to the inclusion of the label backport/1.18.
The below text is copied from the body of the original PR.
Description
This PR started out as comment cleanup but ended up including some functional changes, including eliminating some unused fields and adding the Node TTLs to Workloads (which was discussed previously with Keeler).
The changelog for V2 DNS is also included here.
Testing & Reproduction steps
PR Checklist
external facing docs updatedOverview of commits