Backport of security: triage false positive for go-jose/v3 into release/1.17.x #20904
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hc-github-team-consul-core
force-pushed
the
backport/zalimeni/add-security-triage-go-jose-cve-false-positive/honestly-peaceful-rabbit
branch
from
b26dd1b to
3fb8a90
Compare
hc-github-team-consul-core
requested review from
dekimsey,
jeanneryan and
zalimeni
and removed request for
a team
github-team-consul-core-pr-approver
approved these changes
Mar 26, 2024
zalimeni
added
pr/no-changelog
zalimeni
deleted the
backport/zalimeni/add-security-triage-go-jose-cve-false-positive/honestly-peaceful-rabbit
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport
This PR is auto-generated from #20901 to be assessed for backporting due to the inclusion of the label backport/1.17.
The below text is copied from the body of the original PR.
Per https://osv.dev/vulnerability/GO-2024-2631 this vulnerability is not present in the version currently used (go-jose/v3@3.0.3).
I'm suspicious that the
Introduced 0version in the OSV entry is why we're flagging the fix version as invalid. Just a guess.Description
This unblocks the Consul patch release currently underway.
Testing & Reproduction steps
CI continues to pass including Security Scan check.
PR Checklist
Overview of commits