-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Net 6820 customize mesh gateway limits #20945
Conversation
b747246
to
cf7ea96
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work!
I do think creating a mesh-gateway configuration entry would be better since we're only really adding support for a specific field inside service-defaults to the mesh gateway; however, like you said, now isn't the time for that.
Co-authored-by: Nathan Coleman <nathan.coleman@hashicorp.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this looks good so I'm going to approve. You can wait for approval from others who have more context on this feature.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM otherwise
Description
Allow users of Mesh Gateway to add custom circuit breakers to the mesh gateway XDS config by using a ServiceDefaults object named MeshGateway
Testing & Reproduction steps
Links
PR Checklist