Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: Initial HCP Rebrand #21000

Merged
merged 5 commits into from
Apr 22, 2024
Merged

docs: Initial HCP Rebrand #21000

merged 5 commits into from
Apr 22, 2024

Conversation

boruszak
Copy link
Contributor

Description

This PR updates references to Terraform Cloud in the Consul docs.

Do not merge before 9 AM PST on April 22, 2024.

PR Checklist

  • updated test coverage
  • external facing docs updated
  • appropriate backport labels added
  • not a security concern

@github-actions github-actions bot added type/docs Documentation needs to be created/updated/clarified theme/consul-terraform-sync Relating to Consul Terraform Sync and Network Infrastructure Automation labels Apr 19, 2024
@boruszak boruszak added pr/no-changelog PR does not need a corresponding .changelog entry backport/1.18 and removed theme/consul-terraform-sync Relating to Consul Terraform Sync and Network Infrastructure Automation labels Apr 19, 2024
@boruszak boruszak marked this pull request as ready for review April 19, 2024 21:59
@boruszak boruszak requested a review from a team as a code owner April 19, 2024 21:59
rkoron007
rkoron007 approved these changes Apr 19, 2024
View reviewed changes
Copy link
Contributor

@rkoron007 rkoron007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general looks great! A couple of teeny questions and suggestions

website/content/docs/nia/enterprise/index.mdx Outdated Show resolved Hide resolved
website/content/docs/nia/network-drivers/index.mdx Outdated Show resolved Hide resolved
website/content/docs/nia/network-drivers/terraform-cloud.mdx Outdated Show resolved Hide resolved
website/data/docs-nav-data.json Show resolved Hide resolved
boruszak and others added 2 commits April 19, 2024 15:52
@boruszak @rkoron007
Apply suggestions from code review
aa0af14 
Co-authored-by: Rose M Koron <32436232+rkoron007@users.noreply.github.com>
@boruszak
path fix and redirect
eacd1e1
krastin
krastin approved these changes Apr 22, 2024
View reviewed changes
Copy link
Contributor

@krastin krastin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good! Just needed a little tweak for the nav data 🚀

@krastin krastin merged commit 057ad7e into main Apr 22, 2024
61 checks passed
@krastin krastin deleted the docs/hcp-terraform-rebrand branch April 22, 2024 13:07
@hc-github-team-consul-core hc-github-team-consul-core mentioned this pull request Apr 22, 2024
Merged
4 tasks
@dhiaayachi dhiaayachi mentioned this pull request Sep 26, 2024
Open
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rkoron007 rkoron007 rkoron007 approved these changes

@krastin krastin krastin approved these changes

Assignees
No one assigned
Labels
pr/no-changelog PR does not need a corresponding .changelog entry type/docs Documentation needs to be created/updated/clarified
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@boruszak @krastin @rkoron007