Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[NET-10737] Add CI Checks for Generated Testdata #21613

Merged
merged 10 commits into from
Aug 19, 2024
Merged

[NET-10737] Add CI Checks for Generated Testdata #21613

merged 10 commits into from
Aug 19, 2024

Conversation

jm96441n
Copy link
Member

Description

Adds tests to CI to ensure that xds golden files that are generated for tests are up to date

Testing & Reproduction steps

The core of the script is the following line:

changed_xds_files=$(git --no-pager diff --name-only HEAD "$(git merge-base HEAD "$GITHUB_BASE_REF")" | egrep "agent/xds/testdata/.*")

you can replace $GITHUB_BASE_REF with an earlier release branch (I use origin/release/1.17.x) to see it find diffs for golden files

Links

PR Checklist

  • updated test coverage
  • external facing docs updated
  • appropriate backport labels added
  • not a security concern

@jm96441n jm96441n added pr/no-changelog PR does not need a corresponding .changelog entry backport/all Apply backports for all active releases per .release/versions.hcl labels Aug 16, 2024
@github-actions github-actions bot added type/ci Relating to continuous integration (CI) tooling for testing or releases theme/contributing Additions and enhancements to community contributing materials labels Aug 16, 2024
@jm96441n jm96441n merged commit bc4c479 into main Aug 19, 2024
90 checks passed
@jm96441n jm96441n deleted the NET-10737-check-for-xds-diffs-in-ci branch August 19, 2024 15:49
@hc-github-team-consul-core hc-github-team-consul-core added backport/1.19 This release series is longer active on CE, use backport/ent/1.19 backport/ent/1.17 This release series is longer active on CE or Ent backport/ent/1.15 Changes are backported to 1.15 ent backport/ent/1.18 Changes are backported to 1.18 ent labels Aug 19, 2024
@hc-github-team-consul-core hc-github-team-consul-core mentioned this pull request Aug 19, 2024
Merged
4 tasks
philrenaud pushed a commit that referenced this pull request Sep 12, 2024
@jm96441n @philrenaud
[NET-10737] Add CI Checks for Generated Testdata (#21613)
19f4ddb 
* Add checks to CI to ensure that generated golden files for xds tests are up to date

* fix file permissions

* debugging

* more debugging

* more debugging

* more debugging

* more debugging

* I can't type

* this might be correct

* removing debug prints
@dhiaayachi dhiaayachi mentioned this pull request Sep 25, 2024
Open
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NiniOak NiniOak NiniOak approved these changes

Assignees
No one assigned
Labels
backport/all Apply backports for all active releases per .release/versions.hcl backport/ent/1.15 Changes are backported to 1.15 ent backport/ent/1.17 This release series is longer active on CE or Ent backport/ent/1.18 Changes are backported to 1.18 ent backport/1.19 This release series is longer active on CE, use backport/ent/1.19 pr/no-changelog PR does not need a corresponding .changelog entry theme/contributing Additions and enhancements to community contributing materials type/ci Relating to continuous integration (CI) tooling for testing or releases
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jm96441n @NiniOak @hc-github-team-consul-core