Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update API Group under backendRefs #21961

Merged
merged 2 commits into from
Nov 22, 2024
Merged

Update API Group under backendRefs #21961

merged 2 commits into from
Nov 22, 2024
+2 −2

Conversation

markcampv
Copy link
Contributor

@markcampv markcampv commented Nov 20, 2024 •
edited
Loading

Description

Currently backendRefs refers to api-gateway.consul.hashicorp.com as the API Group that should be used when kind is set to Mesh Service. Based on the mesh service template, it should just be consul.hashicorp.com.

Testing & Reproduction steps

Links

PR Checklist

  • updated test coverage
  • external facing docs updated
  • appropriate backport labels added
  • not a security concern

@markcampv
Update routes.mdx
a1c140d 
Currently backendRefs refers to api-gateway.consul.hashicorp.com as the API Group that should be used when kind is set to Mesh Service. Based on mesh service template, it should just be consul.hashicorp.com.
@markcampv markcampv requested a review from a team as a code owner November 20, 2024 22:52
@github-actions github-actions bot added the type/docs Documentation needs to be created/updated/clarified label Nov 20, 2024
@boruszak boruszak added pr/no-changelog PR does not need a corresponding .changelog entry backport/1.20 Changes are backported to 1.20 labels Nov 21, 2024
boruszak
boruszak approved these changes Nov 21, 2024
View reviewed changes
Copy link
Contributor

@boruszak boruszak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@markcampv markcampv merged commit bbb2e79 into main Nov 22, 2024
80 of 82 checks passed
@markcampv markcampv deleted the docs/change-backendRefs-api-group branch November 22, 2024 00:51
@hc-github-team-consul-core hc-github-team-consul-core mentioned this pull request Nov 22, 2024
Open
4 tasks
@hc-github-team-consul-core
Copy link
Collaborator

📣 Hi @markcampv! a backport is missing for this PR [21961] for versions [1.20] please perform the backport manually and add the following snippet to your backport PR description:

<details>
	<summary> Overview of commits </summary>
		- <<backport commit 1>>
		- <<backport commit 2>>
		...
</details>

1 similar comment
@hc-github-team-consul-core
Copy link
Collaborator

📣 Hi @markcampv! a backport is missing for this PR [21961] for versions [1.20] please perform the backport manually and add the following snippet to your backport PR description:

<details>
	<summary> Overview of commits </summary>
		- <<backport commit 1>>
		- <<backport commit 2>>
		...
</details>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@boruszak boruszak boruszak approved these changes

Assignees
No one assigned
Labels
backport/1.20 Changes are backported to 1.20 pr/no-changelog PR does not need a corresponding .changelog entry type/docs Documentation needs to be created/updated/clarified
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@markcampv @hc-github-team-consul-core @boruszak