-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix the build on Illumos. #2989
Conversation
Update `github.com/docker/docker/pkg/system`.
Test failures appear to be unrelated to this change. |
Hmm this looks like it broke the Windows build:
|
Testing now - if that works I'll tee up a PR to add those. |
I went a few layers deep and it looks like we need to add
Since we are about to cut a release I don't want to update more deps right now. I'm going to revert this for 0.8.2, and then we can update all of Docker for the next release cycle, which will also re-up the deps from the PR. |
This brings in the necessary fix to satisfy hashicorp#2989 without dragging along additional vendor updates reverted in hashicorp#3019.
Update
github.com/docker/docker/pkg/system
.The only actual fix requird is
vendor/github.com/docker/docker/pkg/system/meminfo_solaris.go
but I updated the entire package since it was chalk full of portability fixes.Without this fix it is not possible to build
consul
on Illumos: