Fixes deadlock between barrier write and leader notify channel read .… #3231
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slackpad
reviewed
Jul 6, 2017
agent/consul/server.go
Outdated
| leaderCh := make(chan bool, 1) | ||
| s.config.RaftConfig.NotifyCh = leaderCh | ||
| s.leaderCh = leaderCh | ||
| raftReconcileChannel := make(chan bool, 1) |
There was a problem hiding this comment.
The name "reconcile" has a special meaning where we sync the leader's Serf members with the catalog, so I'd avoid that and change raftReconcileCh to raftNotifyCh for the local variable here, or you could do:
s.raftNotifyCh = make(chan bool, 1)
s.config.RaftConfig.NotifyCh = s.raftNotifyCh
agent/consul/leader.go
Outdated
| @@ -35,13 +36,13 @@ func (s *Server) monitorLeadership() { | |||
| // leaderCh, which is only notified best-effort. Doing this ensures | |||
| // that we get all notifications in order, which is required for | |||
| // cleanup and to ensure we never run multiple leader loops. | |||
| leaderCh := s.leaderCh | |||
| raftNotifyCh := s.raftNotifyChanel | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… Fixes #3230