ui: Namespace authorization integration #6933

johncowen · 2019-12-11T13:50:00Z

This PR is a replacement for #6915.

We will soon have a way to check at startup if Namespaces and ACLs are enabled or not (see #6921), and we can decide whether to show certain UI elements based on that, and also whether to use our disabled or enabled nspace Service.

We also tweaked our config getting so we can check things manually a lot easier without having to restart ember-cli by following the same method that we use to test things out with different datasets.

For other areas of the UI where it would be handy to easily know whether ACLs are enabled or not, we continue to use the old HTTP API approach to avoid changing too much, although we are likely to switch this out and use this config setting moving forwards.

Couple of notes:

This is being merged down onto our namespace feature branch.
This requires Extra templating for the index.html #6921 in order for this to work properly. So that needs merging in a rebasing up before our namespace feature branch goes onto ui-staging

P.S. We did the majority of this work before this PR (hashicorp/nomad#5944 (comment)) from @backspace , but at some point we'll probably use ember-can for this, theres a comment in the below changeset about using a helper - that will probably end up being the helper from ember-can

codecov · 2019-12-11T14:10:35Z

Codecov Report

❗ No coverage uploaded for pull request base (feature/ui-namespaces@fce23da). Click here to learn what that means.
The diff coverage is n/a.

@@                   Coverage Diff                   @@
##             feature/ui-namespaces   #6933   +/-   ##
=======================================================
  Coverage                         ?   65.6%           
=======================================================
  Files                            ?     443           
  Lines                            ?   53312           
  Branches                         ?       0           
=======================================================
  Hits                             ?   34975           
  Misses                           ?   14107           
  Partials                         ?    4230

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fce23da...b87e49c. Read the comment docs.

meirish · 2019-12-17T15:05:20Z

ui-v2/app/serializers/nspace.js

+      // The data properties sent to be saved in the backend
+      // or the same ones that we receive back if its successfull
+      // therefore we can just ignore the result and avoid ember-data
+      // syncing problems


Is it possible for the server to receive additional updates between create and response? (I imagine this would be very much an edge case if so).

Yes definitely possible, but I think blocking queries would reload this into the UI (if you have them enabled of course). I think the other way around is more concerning - so if I load up the edit screen in the UI, then someone makes a change elsewhere and then after than I hit save in the UI.

Ideally we'd need cas for that, but I also have a half baked plan to use blocking queries here to warn you of backend changes on the edit pages, that's still a little way off though.

meirish · 2019-12-17T15:10:08Z

ui-v2/config/environment.js

-    // ENV.APP.LOG_TRANSITIONS = true;
-    // ENV.APP.LOG_TRANSITIONS_INTERNAL = true;
-    // ENV.APP.LOG_VIEW_LOOKUPS = true;
+  switch (true) {


don't think I've seen this before, feels a little tricky though for just two cases though

We'll probably move all the conditional forking here to use the switch statement then we can remove our isDevLike/isProdLike and just use:

case 'development': case 'staging': case 'test': // isDevLike stuff case 'test': // test only break;

So this will grow to more than 2, just I didn't want to change too much here.

meirish · 2019-12-17T15:13:42Z

ui-v2/app/templates/application.hbs

 {{else}}
-{{#hashicorp-consul id="wrapper" dc=dc nspaces=nspaces nspace=nspace}}
+  {{#hashicorp-consul id="wrapper" permissions=permissions dcs=dcs dc=dc nspaces=nspaces nspace=nspace}}


Are the permissions expected to be empty here? If not, I only saw them added to the dc route model - how do they get fetched / populated here?

Ahhh, good spot - these aren't getting set. It doesn't matter too much as this is only for the loading page, which means if you are trying to look for the 'Manage namespaces' button in the namespace dropdown whilst a page is loading, then you won't find it. But also we can't tell if you can view this button as we need to load the API endpoint to check - so we show the loading page! 🐔 🥚

Thing is though, remember I was asking about all the jumping around in the menu when pages where loading - I have a feeling this might be the root of it! I'm going to merge this s is as I don't think this is a major problem and it would be good to get more user testing done here. but I'm definitely gonna take a deeper look at this. We'll probably look at doing what it says in this TODO:

consul/ui-v2/app/routes/dc.js

Lines 5 to 6 in fce23da

// TODO: We should potentially move all these nspace related things

// up a level to application.js

meirish · 2019-12-17T15:17:46Z

ui-v2/app/routes/application.js

@@ -14,7 +14,7 @@ export default Route.extend(WithBlockingActions, {
  init: function() {
    this._super(...arguments);
  },
-  nspaceRepo: service('repository/nspace/disabled'),
+  nspacesRepo: service('repository/nspace/disabled'),


Does this get overwritten by the initializer if namespaces are enabled?

Ah yep, I see it above - maybe a comment here about that would be good just so it's not surprising.

Good call, I think I figured the tests stuff :doh: Will add some comments here in a sec 👍

meirish

Generally the code looks good to me, I left a few questions but nothing major. Are the failing tests due to this or something else? (it looks like there's 13 failing UI tests).

johncowen · 2019-12-17T15:24:05Z

Hmm yeah weird, I just noticed that myself. The pass for me locally, lemme try and kick them off again. If not I'll take a better look before merging, thanks! 🙏

We can't tell if ACLs are enabled or not here, so catch any errors from authorize, as we get a 401 when ACLs are disabled but namespaces are enabled

1. When changing ember config values during development. ember-cli must be stopped and restarted for the changes to take effect, which can get tedious. This change lets developers/engineers set the config values during runtime (and persist them) using Web Inspector as we currently do with our mocking library so manually testing things is less tedious. 2. We also added copious TODOs here as the naming of config vs env is very confusing. 3. We tweaked one spot where we weren't consistently using the nspace vocab.

The data properties sent to be saved in the backend or the same ones that we receive back if its successful therefore we can just ignore the result and avoid ember-data syncing problems

ghost · 2020-01-25T01:54:05Z

Hey there,

This issue has been automatically locked because it is closed and there hasn't been any activity for at least 30 days.

If you are still experiencing problems, or still have questions, feel free to open a new one 👍.

johncowen requested a review from a team December 11, 2019 13:50

johncowen added the theme/ui Anything related to the UI label Dec 11, 2019

johncowen added this to the 1.7.0 milestone Dec 11, 2019

johncowen mentioned this pull request Dec 11, 2019

ui: Namespace Support #6639

Merged

3 tasks

johncowen force-pushed the feature/ui-namespaces branch from 285e779 to 792c4bf Compare December 12, 2019 10:23

johncowen force-pushed the feature/ui-nspace-authorize branch 2 times, most recently from 6faf282 to 25cb78b Compare December 12, 2019 18:49

meirish reviewed Dec 17, 2019

View reviewed changes

meirish approved these changes Dec 17, 2019

View reviewed changes

johncowen force-pushed the feature/ui-namespaces branch from bd932a7 to af3750c Compare December 17, 2019 15:43

johncowen force-pushed the feature/ui-nspace-authorize branch from afb6d90 to 54368a4 Compare December 17, 2019 15:45

johncowen force-pushed the feature/ui-namespaces branch from af3750c to fce23da Compare December 17, 2019 16:19

John Cowen added 13 commits December 17, 2019 16:20

ui: Add authorize / permissions

2bbc6cf

Move authorize to nspace repo temporarily

e52aaa2

Make sure we can POST bodies with an array

6af99e1

Standardize on the 'repo is a plural' rule

5ae0dba

Use CONSUL_BINARY_TYPE to infer namespace support, catch ACLs 401

4769347

We can't tell if ACLs are enabled or not here, so catch any errors from authorize, as we get a 401 when ACLs are disabled but namespaces are enabled

Remove old management setting

78f4010

Remove all trace of UNDEFINED_NSPACE_NAME, and clean up config slightly

3ea81d4

lint

700e757

Remove FIXME, its not relevant anymore

b37caa7

Lint

972f36f

Fix up some tests as a result of URL changes

b038b5e

Accept ember-data as the source of truth instead of Consul for ns CRUD

cf24ecb

The data properties sent to be saved in the backend or the same ones that we receive back if its successful therefore we can just ignore the result and avoid ember-data syncing problems

Make sure things still work in dev mode if you have no cookies

62867d0

johncowen force-pushed the feature/ui-nspace-authorize branch from 54368a4 to 62867d0 Compare December 17, 2019 16:20

John Cowen added 3 commits December 17, 2019 16:37

Comment out the cookie stuff

28194ee

Revert CI test

923e528

Upgrade consul-api-double

b87e49c

johncowen merged commit 871db69 into feature/ui-namespaces Dec 17, 2019

johncowen deleted the feature/ui-nspace-authorize branch December 17, 2019 17:29

ghost locked and limited conversation to collaborators Jan 25, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

ui: Namespace authorization integration #6933

ui: Namespace authorization integration #6933

johncowen commented Dec 11, 2019 •

edited

Loading

codecov bot commented Dec 11, 2019 •

edited

Loading

meirish Dec 17, 2019

johncowen Dec 17, 2019

meirish Dec 17, 2019

johncowen Dec 17, 2019 •

edited

Loading

meirish Dec 17, 2019

johncowen Dec 17, 2019

meirish Dec 17, 2019

meirish Dec 17, 2019

johncowen Dec 17, 2019

meirish left a comment

johncowen commented Dec 17, 2019

ghost commented Jan 25, 2020

	// TODO: We should potentially move all these nspace related things
	// up a level to application.js

ui: Namespace authorization integration #6933

ui: Namespace authorization integration #6933

Conversation

johncowen commented Dec 11, 2019 • edited Loading

codecov bot commented Dec 11, 2019 • edited Loading

Codecov Report

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

johncowen Dec 17, 2019 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

meirish left a comment

Choose a reason for hiding this comment

johncowen commented Dec 17, 2019

ghost commented Jan 25, 2020

johncowen commented Dec 11, 2019 •

edited

Loading

codecov bot commented Dec 11, 2019 •

edited

Loading

johncowen Dec 17, 2019 •

edited

Loading