Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update raft to v1.1.2 #7079

Merged
merged 2 commits into from
Jan 20, 2020
Merged

update raft to v1.1.2 #7079

merged 2 commits into from
Jan 20, 2020

Conversation

hanshasselberg
Copy link
Member

That pulls in the latest raft release and finally fixes #6852. 🦊

@hanshasselberg hanshasselberg requested a review from a team January 17, 2020 13:06
@hanshasselberg hanshasselberg self-assigned this Jan 17, 2020
@mkcp
Copy link
Contributor

mkcp commented Jan 17, 2020

I reran the failed checks in CI -- going verify this by running locally as well

@mkcp
Copy link
Contributor

mkcp commented Jan 17, 2020

Ah, I see, CI explicitly errors out and blocks dependent workflows if there's vendor changes. @hashicorp/consul-core How do we review vendored dep changes?

@mkcp mkcp added the pr/dependencies PR specifically updates dependencies of project label Jan 17, 2020
mkcp
mkcp approved these changes Jan 17, 2020
View reviewed changes
Copy link
Contributor

@mkcp mkcp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I looked over the new deps and double checked w/ team on practices for updating them. Should be good to merge pending make update-vendor push and CI pass. Preemptively approving to drop the lock i'm holding

@hanshasselberg hanshasselberg merged commit 9c1361c into master Jan 20, 2020
@hanshasselberg hanshasselberg deleted the update_raft branch January 20, 2020 12:58
@schristoff schristoff mentioned this pull request Jan 21, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mkcp mkcp mkcp approved these changes

Assignees

@hanshasselberg hanshasselberg

Labels
pr/dependencies PR specifically updates dependencies of project
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Possible deadlock situation when leader is flapping
2 participants
@hanshasselberg @mkcp