Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to miekg/dns v1.1.26 #7252

Merged
merged 1 commit into from
Feb 10, 2020
Merged

Update to miekg/dns v1.1.26 #7252

merged 1 commit into from
Feb 10, 2020

Conversation

mkeeler
Copy link
Member

@mkeeler mkeeler commented Feb 10, 2020

Fixes #6984

DNS tests still seem to run correctly.

@mkeeler mkeeler added this to the 1.7.0 milestone Feb 10, 2020
@mkeeler mkeeler requested a review from a team February 10, 2020 18:16
@mkeeler
Copy link
Member Author

mkeeler commented Feb 10, 2020

Go test failures are flakes (mostly the RPC conn limiting ones that we are working on fixing)
Integ test failure is for 2 envoy versions.

freddygv
freddygv approved these changes Feb 10, 2020
View reviewed changes
Copy link
Contributor

@freddygv freddygv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@mkeeler mkeeler merged commit 58befa7 into master Feb 10, 2020
@mkeeler mkeeler deleted the dependency/miekg/dns branch February 10, 2020 20:14
@onlyjob
Copy link

onlyjob commented Feb 10, 2020

Thanks, @mkeeler. Did you have to make any changes to agent/dns.go in order to accommodate updated 'miekg/dns` and fix FTBFS?

@mkeeler
Copy link
Member Author

mkeeler commented Feb 10, 2020

@onlyjob I looked for the place you mentioned in the issue but it no longer existed in the code (the DNS server in Consul has changed quite a bit since December). We had previously updated to v1.1.22 at some point in time and I am guessing it was fixed then. Regardless, things build and go vet is happy (and no where in our code base are we looking for an ErrTruncated constant)

@onlyjob
Copy link

onlyjob commented Feb 11, 2020

I see, thanks. Good to know that the problem is no longer present in newer Consul. Downstream in Debian we still have 1.5.2 due to hashicorp/nomad#6785

@mikemorris mikemorris mentioned this pull request Feb 11, 2020
Merged
mikemorris pushed a commit that referenced this pull request Feb 11, 2020
@mkeeler @mikemorris
Update to miekg/dns v1.1.26 (#7252)
a155755
mikemorris pushed a commit that referenced this pull request Feb 11, 2020
@mkeeler @mikemorris
Update to miekg/dns v1.1.26 (#7252)
91695f8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@freddygv freddygv freddygv approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.7.0
Development

Successfully merging this pull request may close these issues.

Please update "github.com/miekg/dns"
3 participants
@mkeeler @onlyjob @freddygv