Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support envoy 1.14.2, 1.13.2, 1.12.4 #8057

Merged
merged 1 commit into from
Jun 10, 2020
Merged

Support envoy 1.14.2, 1.13.2, 1.12.4 #8057

merged 1 commit into from
Jun 10, 2020

Conversation

hanshasselberg
Copy link
Member

@hanshasselberg hanshasselberg commented Jun 9, 2020

Checklist

  • Run the full Envoy integration test using the new versions:
make test-envoy-integ ENVOY_VERSIONS="1.14.2"
make test-envoy-integ ENVOY_VERSIONS="1.13.2"
make test-envoy-integ ENVOY_VERSIONS="1.12.4"

@banks
Copy link
Member

banks commented Jun 9, 2020

LGTM! Great job!

The go-test failure thought seems unlikely to be a flake - a newline is missing from the generated bootstrap config but I don't see changes in this PR that would have broken that 🤷

@hanshasselberg hanshasselberg merged commit e62a43c into master Jun 10, 2020
@hanshasselberg hanshasselberg deleted the envoy_1.14.2 branch June 10, 2020 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants