Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specify allowed ingress gateway protocols in docs #8454

Merged
merged 2 commits into from
Aug 7, 2020

Conversation

jackloughran
Copy link
Contributor

It seems like only tls and http are supported right now.

// Protocol declares what type of traffic this listener is expected to
// receive. Depending on the protocol, a listener might support multiplexing
// services over a single port, or additional discovery chain features. The
// current supported values are: (tcp | http).

validProtocols := map[string]bool{
"http": true,
"tcp": true,
}

I found this confusing when I was going through it. I'm hoping this will make someone else's life easier.

@hashicorp-cla
Copy link

hashicorp-cla commented Aug 6, 2020

CLA assistant check
All committers have signed the CLA.

@jsosulska jsosulska requested a review from a team August 6, 2020 22:21
@jsosulska jsosulska added type/docs-cherrypick theme/connect Anything related to Consul Connect, Service Mesh, Side Car Proxies theme/ingress-gw Track ingress work labels Aug 6, 2020
@jsosulska jsosulska requested a review from a team August 6, 2020 22:22
Copy link
Contributor

@freddygv freddygv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR, this request seems reasonable to me.

Requesting one edit.

Co-authored-by: Freddy <freddygv@users.noreply.github.com>
Copy link
Contributor

@freddygv freddygv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@freddygv freddygv changed the title be specific in allowed ingress gateway protocols Specify allowed ingress gateway protocols in docs Aug 7, 2020
@freddygv freddygv merged commit 77d0c33 into hashicorp:master Aug 7, 2020
@hashicorp-ci
Copy link
Contributor

🍒✅ Cherry pick of commit 77d0c33 onto stable-website succeeded!

hashicorp-ci pushed a commit that referenced this pull request Aug 7, 2020
Co-authored-by: Freddy <freddygv@users.noreply.github.com>
@jackloughran jackloughran deleted the patch-1 branch August 7, 2020 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
theme/connect Anything related to Consul Connect, Service Mesh, Side Car Proxies theme/ingress-gw Track ingress work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants