-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Specify allowed ingress gateway protocols in docs #8454
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It seems like only `tls` and `http` are supported right now. https://github.com/hashicorp/consul/blob/d4217cc165aaf863fcbdea400bd2295efb33c4fd/api/config_entry_gateways.go#L44 https://github.com/hashicorp/consul/blob/586ee2566f1b75e675adc66a68639ecf22c69ab3/agent/structs/config_entry_gateways.go#L40 I found this confusing when I was going through it. I'm hoping this will make someone else's life easier.
jsosulska
added
type/docs-cherrypick
theme/connect
Anything related to Consul Connect, Service Mesh, Side Car Proxies
theme/ingress-gw
Track ingress work
labels
Aug 6, 2020
freddygv
suggested changes
Aug 7, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR, this request seems reasonable to me.
Requesting one edit.
Co-authored-by: Freddy <freddygv@users.noreply.github.com>
freddygv
approved these changes
Aug 7, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
freddygv
changed the title
be specific in allowed ingress gateway protocols
Specify allowed ingress gateway protocols in docs
Aug 7, 2020
🍒✅ Cherry pick of commit 77d0c33 onto |
hashicorp-ci
pushed a commit
that referenced
this pull request
Aug 7, 2020
Co-authored-by: Freddy <freddygv@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
theme/connect
Anything related to Consul Connect, Service Mesh, Side Car Proxies
theme/ingress-gw
Track ingress work
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems like only
tls
andhttp
are supported right now.consul/agent/structs/config_entry_gateways.go
Lines 37 to 40 in 586ee25
consul/agent/structs/config_entry_gateways.go
Lines 123 to 126 in 586ee25
I found this confusing when I was going through it. I'm hoping this will make someone else's life easier.