Ensure that Cache options are reloaded when consul reload is performed
#8552
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…med. This will apply cache throttling parameters are properly applied: * cache.EntryFetchMaxBurst * cache.EntryFetchRate When values are updated, a log is displayed in info.
dnephin
reviewed
Aug 26, 2020
There was a problem hiding this comment.
Thank you for the PR! This looks like an excellent addition. One suggestion inline, and a test case for reloading would be great.
A test case in agent/cache/cache_test.go could create a cache, register a MockType, create an entry with Get, then call ReloadOptions, and check that the limiter on the entry has the new values by calling Limit() and Burst().
pierresouchay
force-pushed
the
reload_cache_throttling_config
branch
from
6ad861e
to
879d087
Compare
|
@dnephin All Done |
dnephin
added
backport/1.8
theme/agent-cache
|
🍒✅ Cherry pick of commit 72bf350 onto |
hashicorp-ci
pushed a commit
that referenced
this pull request
Aug 28, 2020
…onfig Ensure that Cache options are reloaded when `consul reload` is performed
|
Oh, I forgot we need to add a changelog entry for this! Hans has some example of how to do that here #8387 if you don't mind adding it. |
pierresouchay
added a commit
to pierresouchay/consul
that referenced
this pull request
Aug 28, 2020
hashicorp-ci
pushed a commit
that referenced
this pull request
Aug 28, 2020
Added changelog for #8552
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will apply cache throttling parameters are properly applied:
When values are updated, a log is displayed in info.
This will help to mitigate #7863 when values need to be updated without any downtime of agents