Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add checkout to dev-upload-s3 #8617

Merged
merged 1 commit into from
Sep 4, 2020
Merged

Conversation

alvin-huang
Copy link
Collaborator

Since the new aws-assume-role step writes creds to the BASH_ENV I forgot we needed to checkout the code in the dev-upload-s3 job now to get the .circleci/bash_env.sh file, otherwise the job fails looking for it to write to.

@alvin-huang alvin-huang requested a review from a team September 4, 2020 14:37
@alvin-huang
Copy link
Collaborator Author

I'm going to merge this in lieu of the dev-upload-s3 passing in my branch now and not having other people's branches break.

@alvin-huang alvin-huang merged commit 2651f73 into master Sep 4, 2020
@alvin-huang alvin-huang deleted the add-checkout-dev-upload-s3 branch September 4, 2020 14:42
@hashicorp-ci
Copy link
Contributor

🍒✅ Cherry pick of commit 2651f73 onto release/1.8.x succeeded!

hashicorp-ci pushed a commit that referenced this pull request Sep 4, 2020
@hashicorp-ci
Copy link
Contributor

🍒✅ Cherry pick of commit 2651f73 onto release/1.7.x succeeded!

hashicorp-ci pushed a commit that referenced this pull request Sep 4, 2020
@hashicorp-ci
Copy link
Contributor

🍒✅ Cherry pick of commit 2651f73 onto release/1.6.x succeeded!

hashicorp-ci pushed a commit that referenced this pull request Sep 4, 2020
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants