Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump components to remove client-side md processing #9773

Merged
merged 1 commit into from
Feb 17, 2021
Merged

Bump components to remove client-side md processing #9773

merged 1 commit into from
Feb 17, 2021

Conversation

zchsh
Copy link
Contributor

@zchsh zchsh commented Feb 16, 2021

This PR bumps @hashicorp/react-vertical-text-block-list and @hashicorp/react-section-header to recently published versions which do not process markdown within the component.

Affected pages

  • /community, should be identical to live site, except the link color should now be "Consul pink", as the current blue link colour is a minor visual bug

@hashicorp-ci
Copy link
Contributor

🤔 This PR has changes in the website/ directory but does not have a type/docs-cherrypick label. If the changes are for the next version, this can be ignored. If they are updates to current docs, attach the label to auto cherrypick to the stable-website branch after merging.

@hashicorp-ci
Copy link
Contributor

🤔 Double check that this PR does not require a changelog entry in the .changelog directory. Reference

@@ -18,27 +18,27 @@ export default function CommunityPage() {
{
header: 'Community Forum',
body:
'[Consul Community Forum](https://discuss.hashicorp.com/c/consul)',
'<a href="https://discuss.hashicorp.com/c/consul">Consul Community Forum</a>',
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

vertical-text-block-list no longer processes markdown internally, so we need to pass it HTML instead. This could be done automatically in getStaticProps if we feel it'd be worth it for authoring convenience.

@@ -21,7 +21,6 @@
@import '~@hashicorp/react-product-downloader/dist/style.css';
@import '~@hashicorp/react-product-features-list/style.css';
@import '~@hashicorp/react-search/style.css';
@import '~@hashicorp/react-section-header/style.css';
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

section-header now uses CSS modules, so this CSS import is no longer needed.

@@ -1,4 +1,6 @@
#p-community {
--brand: var(--consul);
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This ensures links within vertical-text-block-list are styled correctly.

@zchsh zchsh marked this pull request as ready for review February 16, 2021 17:49
@zchsh
Copy link
Contributor Author

zchsh commented Feb 16, 2021

Note: I need to add the type/docs-cherrypick label, but I don't have the permissions to do so

@kylemac kylemac merged commit 531854b into hashicorp:master Feb 17, 2021
@hashicorp-ci
Copy link
Contributor

🍒 If backport labels were added before merging, cherry-picking will start automatically.

To retroactively trigger a backport after merging, add backport labels and re-run https://circleci.com/gh/hashicorp/consul/328399.

@hashicorp-ci
Copy link
Contributor

🍒✅ Cherry pick of commit 531854b onto stable-website succeeded!

@hashicorp-ci
Copy link
Contributor

🍒✅ Cherry pick of commit 531854b onto release/1.9.x succeeded!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants