ui: Implement ACLs access based on ACLs #9835
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🤔 Double check that this PR does not require a changelog entry in the |
johncowen
added
the
pr/no-changelog
johncowen
force-pushed
the
ui/feature/acl-abilities
branch
from
9d0f51f
to
cf12d13
Compare
|
🍒 If backport labels were added before merging, cherry-picking will start automatically. To retroactively trigger a backport after merging, add backport labels and re-run https://circleci.com/gh/hashicorp/consul/336112. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuing on from the work done in #9687 this PR adds restrictions to everything within the ACLs (and nspaces) area based on your ACLs (including readonly views etc.)
An extra note here, in previous version of the UI we have a completely different method of gating access to the ACLs area dating from the beginning of the new UI. This is probably redundant now that we inspect ACLs globally using our new
authorizeendpoint. Whether it is or not is a little unclear as the previous approach also checks for existence of the old ACLs system and whether ACLs are enabled or not. I'll look a bit deeper into this an possibly completely remove all the old style of gating in a separate PR.