Support scheduling for daylight savings #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds support for daylight savings into the library, in the following form: * If the cronexpr isn't satisfied on a day due to leap forward, the day will be skipped. * "30 2 * * *" will not match anytime on 2019-03-10 US/New_York * If an hour is "repeated" due to daylight savings backward transition, the day may have multiple matches * "30 1 * * *" will match twice on 2019-11-03 US/New_York Every second cron expressions will match every second during transition. So will hourly expressions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for daylight savings into the library, in the
following form:
If the cronexpr isn't satisfied on a day due to leap forward, the day
will be skipped.
30 2 * * *will not match anytime on 2019-03-10 US/New_YorkIf an hour is "repeated" due to daylight savings backward transition,
the day may have multiple matches
30 1 * * *will match twice on 2019-11-03 US/New_YorkEvery second cron expressions will match every second during transition.
So will hourly expressions.