Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SegmentedGroup - Convert to TypeScript #2094

Merged
merged 5 commits into from
Jul 25, 2024
Merged

SegmentedGroup - Convert to TypeScript #2094

merged 5 commits into from
Jul 25, 2024

Conversation

didoo
Copy link
Contributor

@didoo didoo commented May 15, 2024 •
edited
Loading

📌 Summary

Converts the SegmentedGroup component to TS

🔗 External links

Jira ticket: https://hashicorp.atlassian.net/issues/HDS-2709

👀 Component checklist

💬 Please consider using conventional comments when reviewing this PR.

@didoo didoo requested a review from a team May 15, 2024 16:01
@vercel Vercel
Copy link

vercel bot commented May 15, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
hds-showcase ✅ Ready (Inspect) Visit Preview Jul 25, 2024 4:32pm
hds-website ✅ Ready (Inspect) Visit Preview Jul 25, 2024 4:32pm

@didoo didoo requested a review from alex-ju May 15, 2024 16:19
@didoo didoo marked this pull request as draft May 15, 2024 16:22
@didoo didoo removed the request for review from alex-ju May 15, 2024 16:23
@didoo didoo force-pushed the segmented-group-ts-conversion branch from 79e7133 to c44a649 Compare May 17, 2024 15:26
@didoo didoo force-pushed the segmented-group-ts-conversion branch from c44a649 to 6ceab0b Compare May 17, 2024 16:29
@didoo didoo force-pushed the segmented-group-ts-conversion branch from 6ceab0b to 0eae3a7 Compare May 17, 2024 17:07
@didoo didoo mentioned this pull request Jun 24, 2024
Merged
@didoo didoo force-pushed the segmented-group-ts-conversion branch from 0eae3a7 to a48984c Compare July 17, 2024 11:07
@didoo didoo force-pushed the segmented-group-ts-conversion branch from a48984c to f8aa71f Compare July 25, 2024 16:14
@hashibot-hds hashibot-hds added the docs-website Content updates to the documentation website label Jul 25, 2024
@didoo didoo changed the base branch from main to alex-ju/typescript/dropdown July 25, 2024 16:15
Base automatically changed from alex-ju/typescript/dropdown to main July 25, 2024 16:22
@didoo didoo marked this pull request as ready for review July 25, 2024 16:26
@hashibot-hds hashibot-hds removed the docs-website Content updates to the documentation website label Jul 25, 2024
alex-ju
alex-ju approved these changes Jul 25, 2024
View reviewed changes
Copy link
Member

@alex-ju alex-ju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙌

@didoo didoo merged commit fc52775 into main Jul 25, 2024
16 checks passed
@didoo didoo deleted the segmented-group-ts-conversion branch July 25, 2024 19:12
@hashibot-hds hashibot-hds mentioned this pull request Jul 25, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alex-ju alex-ju alex-ju approved these changes

Assignees
No one assigned
Labels
packages/components typescript
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@didoo @alex-ju @hashibot-hds