Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tabs TS Conversion #2168

Merged
merged 25 commits into from
Jun 27, 2024
Merged

Tabs TS Conversion #2168

merged 25 commits into from
Jun 27, 2024

Conversation

zamoore
Copy link
Contributor

@zamoore zamoore commented Jun 14, 2024 •
edited
Loading

📌 Summary

If merged, this PR converts the Tabs component and its child components into TypeScript.

🔗 External links

https://hashicorp.atlassian.net/browse/HDS-2714

@vercel Vercel
Copy link

vercel bot commented Jun 14, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
hds-showcase ✅ Ready (Inspect) Visit Preview Jun 27, 2024 2:55pm
hds-website ✅ Ready (Inspect) Visit Preview Jun 27, 2024 2:55pm

@zamoore zamoore changed the title Hds 2714 tabs ts conversion Tabs TS Conversion Jun 16, 2024
@zamoore zamoore force-pushed the HDS-2714-Tabs-ts-conversion branch from 9f70844 to 63e84fa Compare June 18, 2024 15:17
@zamoore zamoore self-assigned this Jun 18, 2024
@zamoore zamoore marked this pull request as ready for review June 18, 2024 21:10
@zamoore zamoore requested a review from a team June 18, 2024 21:10
didoo
didoo reviewed Jun 20, 2024
View reviewed changes
Copy link
Contributor

@didoo didoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zamoore I've left here and there some comments, because maybe there could be a bit more type connections betweens tabs, tab and panel elements. But before making further changes let's see what @alex-ju says, maybe I'm overthinking it.

packages/components/src/components/hds/tabs/index.ts Outdated Show resolved Hide resolved
packages/components/src/components/hds/tabs/index.ts Outdated Show resolved Hide resolved
packages/components/src/components/hds/tabs/index.ts Outdated Show resolved Hide resolved
packages/components/src/components/hds/tabs/index.ts Outdated Show resolved Hide resolved
packages/components/src/components/hds/tabs/index.ts Outdated Show resolved Hide resolved
packages/components/src/components/hds/tabs/index.ts Show resolved Hide resolved
packages/components/src/components/hds/tabs/index.ts Show resolved Hide resolved
packages/components/src/components/hds/tabs/index.ts Show resolved Hide resolved
packages/components/src/components/hds/tabs/panel.ts Outdated Show resolved Hide resolved
packages/components/src/components/hds/tabs/index.ts Outdated Show resolved Hide resolved
alex-ju
alex-ju reviewed Jun 20, 2024
View reviewed changes
Copy link
Member

@alex-ju alex-ju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left a few comments that would bring the component more in line with others in terms of TypeScript

packages/components/src/components/hds/tabs/types.ts Show resolved Hide resolved
packages/components/src/components/hds/tabs/index.ts Outdated Show resolved Hide resolved
packages/components/src/components/hds/tabs/index.ts Outdated Show resolved Hide resolved
packages/components/src/components/hds/tabs/index.ts Outdated Show resolved Hide resolved
packages/components/src/components/hds/tabs/index.ts Outdated Show resolved Hide resolved
packages/components/src/components/hds/tabs/index.ts Show resolved Hide resolved
packages/components/src/components/hds/tabs/panel.ts Outdated Show resolved Hide resolved
packages/components/src/components/hds/tabs/panel.ts Show resolved Hide resolved
@zamoore zamoore requested review from didoo and alex-ju June 20, 2024 19:00
@zamoore zamoore force-pushed the HDS-2714-Tabs-ts-conversion branch from 1011a62 to 72fe6f3 Compare June 25, 2024 19:22
@zamoore zamoore requested review from alex-ju and didoo June 25, 2024 19:43
alex-ju
alex-ju approved these changes Jun 26, 2024
View reviewed changes
Copy link
Member

@alex-ju alex-ju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good! Not an easy component to convert. I noticed there are a few new comments from Cristiano, otherwise it's good to be merged from my perspective.

packages/components/src/components/hds/tabs/index.ts Outdated Show resolved Hide resolved
@didoo
Copy link
Contributor

didoo commented Jun 26, 2024

Looking good! Not an easy component to convert. I noticed there are a few new comments from Cristiano, otherwise it's good to be merged from my perspective.

If @alex-ju approved, consider my comments as non-blockers.

@zamoore zamoore merged commit e73cb8b into main Jun 27, 2024
15 checks passed
@zamoore zamoore deleted the HDS-2714-Tabs-ts-conversion branch June 27, 2024 15:00
@hashibot-hds hashibot-hds mentioned this pull request Jun 26, 2024
Merged
@alex-ju alex-ju mentioned this pull request Jul 2, 2024
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alex-ju alex-ju alex-ju approved these changes

@didoo didoo Awaiting requested review from didoo

Assignees

@zamoore zamoore

Labels
packages/components
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@zamoore @didoo @alex-ju @hashibot-hds