`Hds::Icon` Groundwork #2198

zamoore · 2024-06-28T15:41:08Z

📌 Summary

This PR is part of #2207

If merged, this PR will:

Install @hashicorp/flight-icons as a direct dependency of components
Port the load-sprite instance initialization functionality over from ember-flight-icons to components
Ensure that the load-sprite initializer only runs once. (In existing and new instance initializers)

🔗 External links

Feature branch PR: 2207
Jira ticket: HDS-3515

vercel · 2024-06-28T15:41:11Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Updated (UTC)
hds-showcase	✅ Ready (Inspect)	Visit Preview	Jul 23, 2024 7:49pm
hds-website	✅ Ready (Inspect)	Visit Preview	Jul 23, 2024 7:49pm

yarn.lock

Dhaulagiri · 2024-07-03T14:25:38Z

It doesn't look like the logic for avoiding double insertion of the sprite is working as I see it twice in the website 👀

I'd have to look at it or think on it more, but could be related to it being rendered via prember/fastboot?

zamoore · 2024-07-03T20:55:33Z

@Dhaulagiri I'm unable to reproduce the double loading locally. Maybe something environment related?

didoo · 2024-07-04T07:44:44Z

@zamoore see the deployed preview website: https://hds-website-git-hdsicon-importicons-hashicorp.vercel.app/

zamoore · 2024-07-05T19:33:39Z

@didoo @Dhaulagiri - I had to make the same change to addon-main that I made to the load-sprite initializer for cases where that isn't used. Checked the preview now and it does appear to only load once.

didoo

LGTM

(let's wait for @Dhaulagiri or @alex-ju to approve too, for this one)

alex-ju

Code looks good! I'm happy for us to get it in, assuming we tested this in a product as well.

alex-ju · 2024-07-10T12:44:19Z

packages/components/addon-main.cjs

+      !config.emberFlightIcons?.lazyEmbed &&
+      !config.__flightIconsSpriteLoaded &&


note: I assume the double underscore notation is used to denote the 'internal' nature of this property. across the codebase we have all sorts of notations for this, from __PROPERTY__ to _property and __property that would ideally get aligned in the future

What do you think the best way to document this would be?

didoo · 2024-07-19T09:27:39Z

@zamoore do you think we should do a quick check in Cloud UI using this specific branch, to make sure we're not missing anything? unless you're 100% confident is not necessary to retest what happens if we deploy only this groundwork first

I'll leave it to you to make the call :)

zamoore · 2024-07-22T14:15:24Z

@didoo I'd rather be more cautious than less. I'm going to run a quick test this morning to verify.

hashibot-hds added the packages/components label Jun 28, 2024

vercel bot deployed to Preview – hds-showcase June 28, 2024 15:43 View deployment

vercel bot deployed to Preview – hds-website June 28, 2024 15:45 View deployment

zamoore force-pushed the FEATURE-BRANCH-HdsIcon branch from c922506 to c23bdcb Compare July 2, 2024 17:04

zamoore force-pushed the HdsIcon-import_icons branch from bd5f01d to 088aa8c Compare July 2, 2024 17:16

vercel bot deployed to Preview – hds-showcase July 2, 2024 17:18 View deployment

vercel bot deployed to Preview – hds-website July 2, 2024 17:21 View deployment

zamoore mentioned this pull request Jul 2, 2024

Add Hds::Icon Component - Feature branch [MAIN] #2207

Merged

2 tasks

zamoore changed the title ~~load sprites if they have not been loaded in another initializer~~ Hds::Icon Groundwork Jul 2, 2024

zamoore self-assigned this Jul 2, 2024

hashibot-hds added the packages/ember-flight-icons label Jul 3, 2024

zamoore requested a review from a team July 3, 2024 14:19

zamoore marked this pull request as ready for review July 3, 2024 14:19

vercel bot deployed to Preview – hds-showcase July 3, 2024 14:21 View deployment

didoo reviewed Jul 3, 2024

View reviewed changes

yarn.lock Outdated Show resolved Hide resolved

vercel bot deployed to Preview – hds-website July 3, 2024 14:23 View deployment

vercel bot deployed to Preview – hds-showcase July 5, 2024 19:24 View deployment

vercel bot deployed to Preview – hds-website July 5, 2024 19:26 View deployment

vercel bot deployed to Preview – hds-showcase July 5, 2024 19:49 View deployment

zamoore requested review from didoo and a team July 5, 2024 19:49

vercel bot deployed to Preview – hds-website July 5, 2024 19:50 View deployment

didoo approved these changes Jul 8, 2024

View reviewed changes

didoo requested review from alex-ju and Dhaulagiri July 8, 2024 14:51

alex-ju approved these changes Jul 10, 2024

View reviewed changes

zamoore changed the base branch from FEATURE-BRANCH-HdsIcon to main July 18, 2024 21:24

zamoore force-pushed the HdsIcon-import_icons branch from 79c7bfd to 9980466 Compare July 18, 2024 21:27

vercel bot deployed to Preview – hds-showcase July 18, 2024 21:30 View deployment

vercel bot deployed to Preview – hds-website July 18, 2024 21:32 View deployment

vercel bot deployed to Preview – hds-showcase July 18, 2024 21:42 View deployment

vercel bot deployed to Preview – hds-website July 18, 2024 21:46 View deployment

zamoore added 7 commits July 23, 2024 15:39

added a changet

c5311cf

load sprites if they have not been loaded in another initializer

52dc369

updated the sprite loader in ember-flight-icons to only run once

29a8c54

ensuring that the sprite is not added more than once

d0d3ff3

Update changeset

6cd8717

Updating changeset description

bfbe39d

load sprites if they have not been loaded in another initializer

9972c76

zamoore force-pushed the HdsIcon-import_icons branch from d2c611a to 9972c76 Compare July 23, 2024 19:40

vercel bot deployed to Preview – hds-showcase July 23, 2024 19:42 View deployment

vercel bot deployed to Preview – hds-website July 23, 2024 19:44 View deployment

fixed linting error

9a4e350

vercel bot deployed to Preview – hds-showcase July 23, 2024 19:47 View deployment

vercel bot deployed to Preview – hds-website July 23, 2024 19:49 View deployment

zamoore merged commit 345f693 into main Jul 23, 2024
16 checks passed

zamoore deleted the HdsIcon-import_icons branch July 23, 2024 20:14

hashibot-hds mentioned this pull request Jul 23, 2024

Version Packages #2238

Merged

didoo mentioned this pull request Jul 23, 2024

Website - Add status and version history to recently updated components #2271

Merged

Dhaulagiri mentioned this pull request Jul 26, 2024

add explicit ember-get-config depedency #2283

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

`Hds::Icon` Groundwork #2198

`Hds::Icon` Groundwork #2198

zamoore commented Jun 28, 2024 •

edited by didoo

Loading

vercel bot commented Jun 28, 2024 •

edited

Loading

Dhaulagiri commented Jul 3, 2024 •

edited

Loading

zamoore commented Jul 3, 2024

didoo commented Jul 4, 2024

zamoore commented Jul 5, 2024

didoo left a comment

alex-ju left a comment

alex-ju Jul 10, 2024

zamoore Jul 23, 2024

didoo commented Jul 19, 2024

zamoore commented Jul 22, 2024

		!config.emberFlightIcons?.lazyEmbed &&
		!config.__flightIconsSpriteLoaded &&

Hds::Icon Groundwork #2198

Hds::Icon Groundwork #2198

Conversation

zamoore commented Jun 28, 2024 • edited by didoo Loading

📌 Summary

🔗 External links

vercel bot commented Jun 28, 2024 • edited Loading

Dhaulagiri commented Jul 3, 2024 • edited Loading

zamoore commented Jul 3, 2024

didoo commented Jul 4, 2024

zamoore commented Jul 5, 2024

didoo left a comment

Choose a reason for hiding this comment

alex-ju left a comment

Choose a reason for hiding this comment

alex-ju Jul 10, 2024

Choose a reason for hiding this comment

zamoore Jul 23, 2024

Choose a reason for hiding this comment

didoo commented Jul 19, 2024

zamoore commented Jul 22, 2024

`Hds::Icon` Groundwork #2198

`Hds::Icon` Groundwork #2198

zamoore commented Jun 28, 2024 •

edited by didoo

Loading

vercel bot commented Jun 28, 2024 •

edited

Loading

Dhaulagiri commented Jul 3, 2024 •

edited

Loading