-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SideNav
- Deprecate SideNav::Header::IconButton
(HDS-3770 )
#2354
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
38b0727
to
0be0cb9
Compare
url: 'https://helios.hashicorp.design/components/side-nav?tab=version%20history#480', // TODO: Confirm URL | ||
for: '@hashicorp/design-system-components', | ||
since: { | ||
enabled: '4.9.0', // TODO: Confirm version |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What should I do for the above version numbers and url? Would I edit later shortly before release? (Since I'm not sure what they should be?)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems safe to assume this will land in 4.10 as part of #2330
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But we can always change it directly in the release branch if we need to. Same with the URL, but you could assume it would be https://helios.hashicorp.design/components/side-nav?tab=version%20history#4100 for now
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, thank you!
SideNav
- Deprecate SideNav::Header::IconButton
(HDS-3770 )SideNav
- Deprecate SideNav::Header::IconButton
(HDS-3770 )
Let me know if there's anything I missed in marking this as "deprecated". |
00ca549
to
f1204ef
Compare
This comment was marked as resolved.
This comment was marked as resolved.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
website/docs/components/side-nav/partials/version-history/4.10.0.md
Outdated
Show resolved
Hide resolved
….0.md Co-authored-by: Brian Runnells <1672302+Dhaulagiri@users.noreply.github.com>
Co-authored-by: Cristiano Rastelli <cristiano.rastelli@hashicorp.com>
📌 Summary
If merged, this PR will deprecate the
Hds::SideNav::Header::IconButton
component.Previews:
🛠️ Detailed description
👉 Related reference on deprecating an HDS component or feature
Included changes:
IconButton
Ember component in code:Hds::SideNav::Header::IconButton
withHds::Button
.IconButton
🔗 External links
Jira ticket: HDS-3770
👀 Component checklist
💬 Please consider using conventional comments when reviewing this PR.