feat: update eslint-plugin-ember to latest major version #2427
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Approved Percy because the changes found were just that there are new table sort by selected examples. |
@shleewhite for future reference: I think that rebasing on |
There was a problem hiding this comment.
eslint-plugin-ember v12 brings a fair amount of pivotal changes in how we should write glimmer component. while it is ok to skip some rules while we align our components with the new listing rules I want to make sure we understand these and we plan follow-up work accordingly.
one specific rule that I want us to address as part of this upgrade is empty-glimmer-component-classes – template-only Glimmer components without a backing class are much faster and lighter-weight than those with a backing classes
shleewhite
force-pushed
the
hds-3805/update-eslint-plugin-ember
branch
from
46cc35c
to
652434d
Compare
| @@ -256,7 +256,6 @@ | |||
|
|
|||
| <Frame.Footer> | |||
| <Hds::AppFooter as |AF|> | |||
| {{! @glint-expect-error - TODO: investigate why this line fails }} | |||
There was a problem hiding this comment.
@alex-ju haha fixing the empty class components to templateOnly components revealed an issue with how the AppFooter component imported the types, which I fixed and then I think that fixed the weird typing issue with these files! Who woulda thought.
| import type { HdsAppFooterItemSignature } from './item.ts'; | ||
| import type { HdsAppFooterLegalLinksSignature } from './legal-links'; | ||
| import type { HdsAppFooterLinkSignature } from './link'; | ||
| import type { HdsAppFooterStatusLinkSignature } from './status-link'; |
shleewhite
force-pushed
the
hds-3805/update-eslint-plugin-ember
branch
from
64fc90e
to
c87f966
Compare
shleewhite
force-pushed
the
hds-3805/update-eslint-plugin-ember
branch
from
c87f966
to
2c53f5c
Compare
📌 Summary
If merged, this PR would upgrade eslint-plugin-ember to the latest version and includes some fixes to get the lint to pass:
gtsfiles in showcase and components🔗 External links
Jira ticket: HDS-3805
👀 Component checklist
💬 Please consider using conventional comments when reviewing this PR.