DialogPrimitive: add a guard so the yielded close function is always defined
#2453
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
shleewhite
force-pushed
the
hds-3889/fix-dialog-footer-close
branch
from
9ab6f50 to
7a03dc9
Compare
didoo
reviewed
Sep 25, 2024
alex-ju
reviewed
Sep 25, 2024
shleewhite
force-pushed
the
hds-3889/fix-dialog-footer-close
branch
from
ff7d2be to
7a03dc9
Compare
alex-ju
approved these changes
Sep 25, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📌 Summary
If merged, this PR would create a
onDismissgetter in the DialogPrimitive so the close function that is yielded to the Footer is always defined.🔗 External links
Jira ticket: HDS-3889
👀 Component checklist
💬 Please consider using conventional comments when reviewing this PR.