Update SuperSelect selected list item style
#2479
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
jorytindall
commented
Oct 3, 2024
|
|
||
| &:hover, | ||
| &.mock-hover { | ||
| color: var(--token-color-foreground-action-hover); |
There was a problem hiding this comment.
I couldn't find a way to not duplicate these interactive styles between aria-current="true" and aria-selected="true", so if there's a better way, I'm all for it!
LilithJames-HDS
approved these changes
Oct 3, 2024
shleewhite
approved these changes
Oct 4, 2024
Merged
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📌 Summary
If merged this PR updates the default/resting state of selected list items in the
SuperSelecttoForeground / Primaryto match other list items and theDropdowncomponent.📸 Screenshots
Before:
After:
🔗 External links
Jira ticket: HDS-3942
Figma file: Figma v2.0 Libraries | SuperSelect
👀 Component checklist
💬 Please consider using conventional comments when reviewing this PR.