Alert - don't use role or aria-live for non-valid alert usages (HDS-3919)
#2500
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
This comment was marked as outdated.
This comment was marked as outdated.
KristinLBradley
commented
Oct 11, 2024
KristinLBradley
changed the title
Alert - don't use role=alert or aria-live for non-valid alert types ("colors") (HDS-3919)Alert - don't use role=alert or aria-live for non-valid alert usages (HDS-3919)
KristinLBradley
changed the title
Alert - don't use role=alert or aria-live for non-valid alert usages (HDS-3919)Alert - don't use role or aria-live for non-valid alert usages (HDS-3919)
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
KristinLBradley
force-pushed
the
hds-3919-alert-non-alert-usage-variant
branch
from
aecb5f3 to
4957686
Compare
|
@KristinLBradley Toasts, from a UX perspective, behave differently. For a neutral/highlight toast, a user may need to still need to be aware of it even if it's simply communicating a "process has started." Especially because a Toast is considered "temporary" (either times out or is dimissed). I do not believe anyone currently uses it for promotional purposes (nor should they ever) as they are never contextual. So I think the two are different use cases. |
didoo
reviewed
Oct 16, 2024
MelSumner
approved these changes
Oct 16, 2024
…ate and fix tests
KristinLBradley
force-pushed
the
hds-3919-alert-non-alert-usage-variant
branch
from
bffbad8 to
9b35f4a
Compare
Co-authored-by: Andrew Gendel <124841193+andgen404@users.noreply.github.com> Co-authored-by: Melanie Sumner <melanie@hashicorp.com> Co-authored-by: Heather Larsen <hlarsen@hashicorp.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
STATUS:
📌 Summary
If merged, this PR changes the
Alertto not set a default role or aria-live value for "neutral" or "highlight" alerts.👉 Docs branch: NEW - #2509
(OLD -
#2507)🔗 External links
👀 Component checklist
💬 Please consider using conventional comments when reviewing this PR.