Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SuperSelect::Multiple - allow custom result count message #2502

Merged
merged 3 commits into from
Oct 14, 2024

Conversation

alex-ju
Copy link
Member

@alex-ju alex-ju commented Oct 14, 2024

📌 Summary

Allow override of custom result count message via @resultCountMessage argument. This argument is already part of the PowerSelect signature, but we currently provide a default value in the SuperSelect wrapper without allowing consumers to override it.

🔗 External links

Jira ticket: HDS-3986


👀 Component checklist

💬 Please consider using conventional comments when reviewing this PR.

Copy link

vercel bot commented Oct 14, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
hds-showcase ✅ Ready (Inspect) Visit Preview Oct 14, 2024 1:52pm
hds-website ✅ Ready (Inspect) Visit Preview Oct 14, 2024 1:52pm

@alex-ju alex-ju merged commit 7142a93 into main Oct 14, 2024
14 checks passed
@alex-ju alex-ju deleted the alex-ju/super-select-custom-result-count-message branch October 14, 2024 16:37
@hashibot-hds hashibot-hds mentioned this pull request Oct 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs-website Content updates to the documentation website packages/components showcase
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants