Dropdown - fix dropdown content not being preserved when interacted with
#2506
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
didoo
approved these changes
Oct 15, 2024
| @@ -13,6 +13,7 @@ | |||
| ) | |||
| }} | |||
| <div | |||
| tabindex="-1" | |||
There was a problem hiding this comment.
That's what I noticed the other day when doing the code review, that this tabindex was missing: https://github.com/hashicorp/design-system/blob/main/packages/components/src/components/hds/menu-primitive/index.hbs#L16
(but then I thought we would have noticed if it was important, so I didn't say anything; well, we noticed 🤦♂️)
The PopoverPrimitive assumes the popover element is focusable and registers a focusout event on the main popover container to determine when to hide the container. When the popover element is not focusable any event will trigger a focusout and close the popover. To resolve this we make the popover container focusable using `tabindex="-1"`
alex-ju
force-pushed
the
alex-ju/dropdown-focusout-fix
branch
from
29392da to
68348f9
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📌 Summary
Fixed an issue where the dropdown content was not preserved when interacted with.
🛠️ Detailed description
The PopoverPrimitive assumes the popover element is focusable and registers a
focusoutevent on the main popover container to determine when to hide the container. When the popover element is not focusable, any interaction will trigger afocusoutand close the popover. To resolve this we make the popover container focusable usingtabindex="-1".🔗 External links
Jira ticket: HDS-3994
👀 Component checklist
💬 Please consider using conventional comments when reviewing this PR.