Time - component (HDS-3945)
#2515
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
KristinLBradley
force-pushed
the
hds-3945-date-time-display
branch
from
880c9b4 to
725c1b4
Compare
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
KristinLBradley
commented
Oct 29, 2024
|
Merged the docs branch into this one. |
KristinLBradley
commented
Dec 4, 2024
KristinLBradley
commented
Dec 5, 2024
alex-ju
previously approved these changes
Dec 5, 2024
| @@ -47,6 +47,7 @@ | |||
| "ember-a11y-refocus": "^4.1.3", | |||
| "ember-cli-sass": "^11.0.1", | |||
| "ember-composable-helpers": "^5.0.0", | |||
| "ember-concurrency": "^4.0.2", | |||
There was a problem hiding this comment.
4.0.2 is fine, it's the latest. yarn will decide the exact version in the resolution process
alex-ju
approved these changes
Dec 5, 2024
Merged
didoo
reviewed
Dec 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📌 Summary
If merged, this PR will add the
Timecomponent and service to HDS.Related:
Time- docs (HDS-4161) #2557Product tests:
🔗 External links
👀 Component checklist
💬 Please consider using conventional comments when reviewing this PR.