hds-clipboard: add clipboard-polyfill to support more environments
#2525
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Dhaulagiri
reviewed
Oct 29, 2024
Dhaulagiri
reviewed
Oct 30, 2024
alex-ju
reviewed
Oct 30, 2024
alex-ju
approved these changes
Oct 30, 2024
Dhaulagiri
reviewed
Oct 31, 2024
| // to test that this works in a non-secure context, access the port through your IP address (ie. XXX.XXX.X.XXX:4200/) | ||
| if (!navigator.clipboard) { | ||
| try { | ||
| const clipboard = await import('clipboard-polyfill'); |
There was a problem hiding this comment.
Nice! Thanks for taking the time to sort this out 👏
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📌 Summary
If merged, this PR would include the
clipboard-polyfillin HDS. Ifnavigator.clipboard.writeText(textToCopy);fails andnavigator.clipboarddoesn't exist - it will fallback on the polyfill.🔗 External links
Jira ticket: HDS-3840
👀 Component checklist
- [ ] Percy was checked for any visual regression💬 Please consider using conventional comments when reviewing this PR.