Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve sass warnings in rollup build #2594

Merged
merged 2 commits into from
Dec 13, 2024
Merged

Conversation

alex-ju
Copy link
Member

@alex-ju alex-ju commented Dec 9, 2024

📌 Summary

The following changes will silence sass warnings raised by rollup-plugin-scss when building our CSS via yarn build

  • map-get is deprecated in favor of map.get (available via sass:map)
  • @import is deprecated in favor of @use

Compared the CSS output in dist and it is identical before and after the change.


🔗 External links

👀 Component checklist

💬 Please consider using conventional comments when reviewing this PR.

Copy link

vercel bot commented Dec 9, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
hds-showcase ✅ Ready (Inspect) Visit Preview Dec 13, 2024 2:54pm
hds-website ✅ Ready (Inspect) Visit Preview Dec 13, 2024 2:54pm

@alex-ju alex-ju marked this pull request as ready for review December 11, 2024 13:07
@alex-ju alex-ju requested a review from a team as a code owner December 11, 2024 13:07
didoo
didoo previously approved these changes Dec 11, 2024
Copy link
Contributor

@didoo didoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not tested in a live environment, but checked only the code itself. Didn't see anything out of order (plus Percy is not complaining) so it's a 👍 for me.

@KristinLBradley
Copy link
Contributor

🚢𓂃

@alex-ju alex-ju merged commit 6938efb into main Dec 13, 2024
14 checks passed
@alex-ju alex-ju deleted the alex-ju/resolve-sass-warnings branch December 13, 2024 15:18
@hashibot-hds hashibot-hds mentioned this pull request Dec 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants