Tag
- Overflow with longer text fix
#2627
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📌 Summary
If merged, this PR would fix an issue observe in the
Tag
where the dismiss button background overflows the border when the text wraps to multiple lines. It would also improve the support for longer text in the tags used inSuperSelect::Multiple
.🛠️ Detailed description
It was observed in the
Tag
that when the text exceeds 3 lines, the background of the dismiss button obscures the border of the element.Reducing the border radius of the tag set with
$hds-tag-border-radius
from50px
to20px
resulted in the overflow issue being fixed with 3 lines of text.While the change would create visual changes for tags with more than 3 lines of text, there are no visual changes to tags with 1 or 2 lines.
The
$hds-tag-border-radius
variable is also used in theSuperSelect::Multiple
, and updating this value to20px
as well improved the readability of the tags with longer text.📸 Screenshots
Tag
- BeforeTag
- AfterSuperSelect::Multiple
- BeforeSuperSelect::Multiple
- After🔗 External links
Jira ticket: HDS-3854
👀 Component checklist
💬 Please consider using conventional comments when reviewing this PR.