Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tag - Overflow with longer text fix #2627

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

Conversation

dchyun
Copy link
Contributor

@dchyun dchyun commented Dec 26, 2024

📌 Summary

If merged, this PR would fix an issue observe in the Tag where the dismiss button background overflows the border when the text wraps to multiple lines. It would also improve the support for longer text in the tags used in SuperSelect::Multiple.

🛠️ Detailed description

It was observed in the Tag that when the text exceeds 3 lines, the background of the dismiss button obscures the border of the element.

Reducing the border radius of the tag set with $hds-tag-border-radius from 50px to 20px resulted in the overflow issue being fixed with 3 lines of text.

While the change would create visual changes for tags with more than 3 lines of text, there are no visual changes to tags with 1 or 2 lines.

The $hds-tag-border-radius variable is also used in the SuperSelect::Multiple, and updating this value to 20px as well improved the readability of the tags with longer text.

📸 Screenshots

Tag - Before
Screenshot 2024-12-26 at 10 24 59 AM

Tag - After
Screenshot 2024-12-26 at 10 25 52 AM

SuperSelect::Multiple - Before
Screenshot 2024-12-26 at 10 28 02 AM

SuperSelect::Multiple - After
Screenshot 2024-12-26 at 10 28 16 AM

🔗 External links

Jira ticket: HDS-3854


👀 Component checklist

💬 Please consider using conventional comments when reviewing this PR.

Copy link

vercel bot commented Dec 26, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
hds-showcase ✅ Ready (Inspect) Visit Preview Dec 26, 2024 5:30pm
hds-website ✅ Ready (Inspect) Visit Preview Dec 26, 2024 5:30pm

@hashibot-hds hashibot-hds added packages/components docs-website Content updates to the documentation website labels Dec 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs-website Content updates to the documentation website packages/components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants